Re: Review Request 52190: Removed deprecated compiler warnings.

2016-12-19 Thread Daniel Pravat 


> On Nov. 23, 2016, 9:27 p.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake, lines 97-98
> > 
> >
> > Can you add some comments above these?
> > 
> > I presume that the first definition silences some MSVC or CRT warnings. 
> >  But what does the second definition do?

These defines are used to suppress the warnings from Winsock APIs used in 
int_fd.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/#review156785
---


On Nov. 23, 2016, 5:12 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52190/
> ---
> 
> (Updated Nov. 23, 2016, 5:12 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed deprecated compiler warnings.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 
> 
> Diff: https://reviews.apache.org/r/52190/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/#review156822
---



Patch looks great!

Reviews applied: [52190]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2016, 5:12 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52190/
> ---
> 
> (Updated Nov. 23, 2016, 5:12 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed deprecated compiler warnings.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 
> 
> Diff: https://reviews.apache.org/r/52190/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/#review156785
---




cmake/CompilationConfigure.cmake (lines 97 - 98)


Can you add some comments above these?

I presume that the first definition silences some MSVC or CRT warnings.  
But what does the second definition do?


- Joseph Wu


On Nov. 23, 2016, 9:12 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52190/
> ---
> 
> (Updated Nov. 23, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed deprecated compiler warnings.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 
> 
> Diff: https://reviews.apache.org/r/52190/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/
---

(Updated Nov. 23, 2016, 5:12 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph 
Wu, and Michael Park.


Repository: mesos


Description
---

Removed deprecated compiler warnings.


Diffs
-

  cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 

Diff: https://reviews.apache.org/r/52190/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-23 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/
---

(Updated Nov. 23, 2016, 4:12 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph 
Wu, and Michael Park.


Repository: mesos


Description
---

Removed deprecated compiler warnings.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 

Diff: https://reviews.apache.org/r/52190/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 52190: Removed deprecated compiler warnings.

2016-11-22 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/
---

(Updated Nov. 23, 2016, 6:56 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph 
Wu, and Michael Park.


Repository: mesos


Description
---

Removed deprecated compiler warnings.


Diffs
-

  cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 

Diff: https://reviews.apache.org/r/52190/diff/


Testing
---


Thanks,

Daniel Pravat

Review Request 52190: Removed deprecated compiler warnings.

2016-11-13 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52190/
---

Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph 
Wu, and Michael Park.


Summary (updated)
-

Removed deprecated compiler warnings.


Repository: mesos


Description (updated)
---

Removed deprecated compiler warnings.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 

Diff: https://reviews.apache.org/r/52190/diff/


Testing
---


Thanks,

Daniel Pravat