Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

2016-12-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/#review157861 --- Ship it! Ship It! - Joseph Wu On Nov. 13, 2016, 9:47 p.m.,

Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

2016-11-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52210: Fixed warnings in getcwd.hpp.

2016-09-28 Thread Daniel Pravat
> On Sept. 29, 2016, 12:32 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/getcwd.hpp, line 27 > > > > > > This doesn't seem correct. > > > > `getcwd()` on Posix is: > > ``` > > char

Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

2016-09-28 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/ --- (Updated Sept. 29, 2016, 3:32 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52210: Fixed warnings in getcwd.hpp.

2016-09-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/#review150791 --- 3rdparty/stout/include/stout/os/getcwd.hpp (line 27)

Review Request 52210: Fixed warnings in getcwd.hpp.

2016-09-22 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos