Re: Review Request 52544: Introduced `int_fd` class.

2016-11-30 Thread Daniel Pravat
> On Nov. 19, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 381-384 > > > > > > Do we actually need this? I think the `int` on the rhs should implicit >

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-29 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 30, 2016, 7:54 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-29 Thread Daniel Pravat
> On Nov. 19, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 381-384 > > > > > > Do we actually need this? I think the `int` on the rhs should implicit >

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 23, 2016, 5:20 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156376 --- 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-18 Thread Michael Park
> On Nov. 16, 2016, 4:57 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 36-38 > > > > > > What are these for? > > Daniel Pravat wrote: > closed is used to detect

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-16 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 17, 2016, 7:09 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-16 Thread Daniel Pravat
> On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 416-440 > > > > > > What is this used for? This is called from the function below. It is

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156151 --- 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp (line

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-16 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 16, 2016, 6:37 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu, Alex