Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review164303 --- Ship it! I greatly appreciate the goal of maintaining the integ

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
> On Feb. 5, 2017, 8:48 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/windows/fd.hpp, line 59 > > > > > > I'm not super up on the semantics of these newfangled C++11 constructor > > things, but is the

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Michael Park
> On Feb. 5, 2017, 12:48 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/windows/fd.hpp, line 306 > > > > > > I'm a bit confused about the conversion logic here... if `left` is a > > CRT type, can't we

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Michael Park
> On Feb. 5, 2017, 12:48 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/windows/fd.hpp, line 306 > > > > > > I'm a bit confused about the conversion logic here... if `left` is a > > CRT type, can't we

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Feb. 5, 2017, 5:04 p.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Michael Park
> On Feb. 5, 2017, 12:48 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/windows/fd.hpp, line 59 > > > > > > I'm not super up on the semantics of these newfangled C++11 constructor > > things, but is th

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Feb. 5, 2017, 1:24 p.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review164276 --- 3rdparty/stout/include/stout/os.hpp (line 49)

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review164273 --- 3rdparty/stout/include/stout/os/windows/fd.hpp (line 20)

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Feb. 4, 2017, 5:36 p.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-01-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Jan. 9, 2017, 6:47 p.m.) Review request for mesos, Daniel Pravat and J

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2016-12-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Dec. 21, 2016, 3:41 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2016-12-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Dec. 20, 2016, 2:29 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2016-12-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Dec. 15, 2016, 5:41 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2016-12-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Dec. 14, 2016, 3:50 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2016-12-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review159213 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 8:45 p.m

Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2016-12-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- Review request for mesos and Daniel Pravat. Repository: mesos Description ---