Re: Review Request 55549: Windows: Added health checker to build.

2017-01-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55549/#review163171 --- Ship it! Ship It! - Joseph Wu On Jan. 26, 2017, 12:45 a.m.,

Re: Review Request 55549: Windows: Added health checker to build.

2017-01-26 Thread Joseph Wu
> On Jan. 24, 2017, 1:37 p.m., Joseph Wu wrote: > > src/health-check/tcp_connect.cpp, lines 33-38 > > > > > > Libprocess headers should go above stout headers. > > Alex Clemmer wrote: > Oh, did this change

Re: Review Request 55549: Windows: Added health checker to build.

2017-01-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55549/ --- (Updated Jan. 26, 2017, 8:45 a.m.) Review request for mesos, Andrew

Re: Review Request 55549: Windows: Added health checker to build.

2017-01-26 Thread Alex Clemmer
> On Jan. 24, 2017, 9:37 p.m., Joseph Wu wrote: > > src/health-check/tcp_connect.cpp, lines 33-38 > > > > > > Libprocess headers should go above stout headers. Oh, did this change recently, or have I just always

Re: Review Request 55549: Windows: Added health checker to build.

2017-01-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55549/#review162853 --- src/health-check/CMakeLists.txt

Review Request 55549: Windows: Added health checker to build.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55549/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.