Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-02-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/ --- (Updated Feb. 1, 2017, 11:19 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Guangya Liu
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? > > Jiang Yan Xu wrote: > `framework2offers` is

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Jiang Yan Xu
> On Jan. 31, 2017, 5:06 p.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? > > Jiang Yan Xu wrote: > `framework2offers`

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Jiang Yan Xu
> On Jan. 31, 2017, 5:06 p.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? > > Jiang Yan Xu wrote: > `framework2offers`

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Guangya Liu
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? > > Jiang Yan Xu wrote: > `framework2offers` is

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Guangya Liu
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? > > Jiang Yan Xu wrote: > `framework2offers` is

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Jiang Yan Xu
> On Jan. 31, 2017, 5:06 p.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? > > Jiang Yan Xu wrote: > `framework2offers`

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Guangya Liu
> On 二月 1, 2017, 1:06 a.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? > > Jiang Yan Xu wrote: > `framework2offers` is

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Jiang Yan Xu
> On Jan. 31, 2017, 5:06 p.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > > > > > This is only checking one offer but not two? `framework2offers` is a `Queue`, calling

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/#review163762 --- src/tests/master_allocator_tests.cpp (lines 1750 - 1751)

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-31 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/ --- (Updated Jan. 31, 2017, 1:03 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-30 Thread Jacob Janco
> On Jan. 30, 2017, 11:51 p.m., Jacob Janco wrote: > > Ship It! > > Jacob Janco wrote: > Makes sense, with batched allocation recovery and allocation can be > interleaved causing flakiness in this test. Passed --gtest_repeat=1000 - Jacob

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-30 Thread Jacob Janco
> On Jan. 30, 2017, 11:51 p.m., Jacob Janco wrote: > > Ship It! Makes sense, with batched allocation recovery and allocation can be interleaved causing flakiness in this test. - Jacob --- This is an automatically generated e-mail. To

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-30 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/#review163594 --- Ship it! Ship It! - Jacob Janco On Jan. 23, 2017, 7:08

Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/#review162732 --- Patch looks great! Reviews applied: [55852] Passed command:

Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.

2017-01-23 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/ --- Review request for mesos, Guangya Liu and Jacob Janco. Bugs: MESOS-6904