Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review168955 --- Ship it! Committing soon with the following minor edits.

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-12 Thread Anindya Sinha
> On March 11, 2017, 8:44 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 1812-1823 (original), 1813-1822 (patched) > > > > > > This comment to me is more misleading than helping. I don't understand >

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-12 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated March 12, 2017, 8:05 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-11 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review168693 --- Fix it, then Ship it! Overall LGTM, just some nits.

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-10 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated March 10, 2017, 10:15 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-10 Thread Anindya Sinha
> On March 10, 2017, 8:05 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Line 1807 (original), 1832-1834 (patched) > > > > > > As discussed offline, the overall logic about `_run` continuations is > >

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review168570 --- src/slave/slave.cpp Line 1807 (original), 1832-1834 (patched)

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-08 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated March 8, 2017, 11:17 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-07 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated March 7, 2017, 11:19 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-07 Thread Anindya Sinha
> On March 2, 2017, 9:26 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 1830-1840 (original), 1818-1835 (patched) > > > > > > This results in a behavior change: if tasks are killed during > >

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-06 Thread Jiang Yan Xu
> On March 2, 2017, 1:26 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 1830-1840 (original), 1818-1835 (patched) > > > > > > This results in a behavior change: if tasks are killed during > >

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-06 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review167750 --- src/slave/slave.hpp Lines 340 (patched)

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-03 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated March 3, 2017, 8:08 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-03 Thread Anindya Sinha
> On March 2, 2017, 9:26 a.m., Jiang Yan Xu wrote: > > src/slave/slave.hpp > > Lines 152-153 (original), 152-153 (patched) > > > > > > If we are keeping the original semantics of `_run`, do we still need to > >

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review167654 --- src/slave/slave.hpp Lines 152-153 (original), 152-153 (patched)

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-03-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated March 1, 2017, 4:15 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-27 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated Feb. 28, 2017, 1:17 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-27 Thread Anindya Sinha
> On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1722 > > > > > > Why not TASK_ERROR? > > Anindya Sinha wrote: > AFAICT, `TASK_ERROR` is only generated from the master and never

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review166890 --- src/slave/slave.cpp (line 1706)

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-27 Thread Jiang Yan Xu
> On Feb. 19, 2017, 11:07 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1722 > > > > > > Why not TASK_ERROR? > > Anindya Sinha wrote: > AFAICT, `TASK_ERROR` is only generated from the master and

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-20 Thread Anindya Sinha
> On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1713 > > > > > > s/tasks(s) // > > because it's already in `taskOrTaskGroup`? > > > > Also s/WARNING/ERROR/ because

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-20 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated Feb. 21, 2017, 7:20 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review165999 --- src/slave/slave.cpp (line 1662)

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review164351 --- src/slave/slave.cpp (line 1659)

Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-01-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- Review request for mesos, Adam B and Jiang Yan Xu. Bugs: MESOS-6953