Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-11 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56378/#review165246
---



Patch looks great!

Reviews applied: [56327, 56328, 56330, 56371, 56373, 56374, 56376, 56378]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 11, 2017, 10:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56378/
> ---
> 
> (Updated Feb. 11, 2017, 10:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
> https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for suppress and revive with multi role framework.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> a866d03c0b7a676d08fb2fb1e321133c9f5363fc 
> 
> Diff: https://reviews.apache.org/r/56378/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  
> --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole"
>  --gtest_repeat=100
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-11 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56378/
---

(Updated 二月 11, 2017, 10:29 a.m.)


Review request for mesos, Benjamin Mahler and Jay Guo.


Bugs: MESOS-6638
https://issues.apache.org/jira/browse/MESOS-6638


Repository: mesos


Description
---

Added test case for suppress and revive with multi role framework.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
a866d03c0b7a676d08fb2fb1e321133c9f5363fc 

Diff: https://reviews.apache.org/r/56378/diff/


Testing
---

make
make check

```
./bin/mesos-tests.sh  
--gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole" 
--gtest_repeat=100
```


Thanks,

Guangya Liu

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-10 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56378/#review165214
---


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp (line 3690)


Hm.. why did you need this?



src/tests/hierarchical_allocator_tests.cpp (line 3703)


Did you mean to do 1000.0 or 1000? How about using something like 
`Days(1).secs()`?



src/tests/hierarchical_allocator_tests.cpp (lines 3723 - 3724)


How about putting this above the revive call? E.g.

```
  // Revive offers for role1, after which the agent's resources
  // should be offered to it.
  allocator->reviveOffers(framework.id(), "role1");

  expected = Allocation(
  framework.id(),
  {{"role1", {{agent.id(), agent.resources());

  AWAIT_EXPECT_EQ(expected, allocation);
```


- Benjamin Mahler


On Feb. 7, 2017, 10:10 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56378/
> ---
> 
> (Updated Feb. 7, 2017, 10:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
> https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for suppress and revive with multi role framework.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> c681d03c3f94f7d071143366a5aad0421108ebec 
> 
> Diff: https://reviews.apache.org/r/56378/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  
> --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole"
>  --gtest_repeat=100
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-07 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56378/#review164640
---



Maybe add a test to check master suppress/revive validation code path too?

- Jay Guo


On Feb. 7, 2017, 6:10 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56378/
> ---
> 
> (Updated Feb. 7, 2017, 6:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
> https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for suppress and revive with multi role framework.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> c681d03c3f94f7d071143366a5aad0421108ebec 
> 
> Diff: https://reviews.apache.org/r/56378/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  
> --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole"
>  --gtest_repeat=100
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-07 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56378/#review164580
---



Patch looks great!

Reviews applied: [56327, 56328, 56330, 56371, 56373, 56374, 56376, 56378]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 7, 2017, 10:10 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56378/
> ---
> 
> (Updated Feb. 7, 2017, 10:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
> https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case for suppress and revive with multi role framework.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> c681d03c3f94f7d071143366a5aad0421108ebec 
> 
> Diff: https://reviews.apache.org/r/56378/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  
> --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole"
>  --gtest_repeat=100
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-07 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56378/
---

Review request for mesos, Benjamin Mahler and Jay Guo.


Bugs: MESOS-6638
https://issues.apache.org/jira/browse/MESOS-6638


Repository: mesos


Description
---

Added test case for suppress and revive with multi role framework.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
c681d03c3f94f7d071143366a5aad0421108ebec 

Diff: https://reviews.apache.org/r/56378/diff/


Testing
---

make
make check

```
./bin/mesos-tests.sh  
--gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole" 
--gtest_repeat=100
```


Thanks,

Guangya Liu