Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-03-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/#review168545 --- Ship it! Ship It! - Vinod Kone On March 8, 2017, 2:10 p.m.,

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-03-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/ --- (Updated March 8, 2017, 3:10 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-03-08 Thread Jan Schlicht
> On March 7, 2017, 9:19 p.m., Vinod Kone wrote: > > 3rdparty/stout/include/stout/base64.hpp > > Lines 181 (patched) > > > > > > why does this function take padding as an argument but not `encode`? > > > >

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-03-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/#review168179 --- 3rdparty/stout/include/stout/base64.hpp Lines 178-179 (patched)

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-03-03 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/ --- (Updated March 3, 2017, 3 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-03-03 Thread Jan Schlicht
> On Feb. 28, 2017, 11:16 p.m., Greg Mann wrote: > > 3rdparty/stout/tests/base64_tests.cpp > > Lines 48-69 (patched) > > > > > > Could we use strings for these tests that include both of the modified > > alphabet

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-02-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/#review167145 --- Fix it, then Ship it! 3rdparty/stout/include/stout/base64.hpp

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-02-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/ --- (Updated Feb. 22, 2017, 3:24 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-02-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/#review166054 --- 3rdparty/stout/include/stout/base64.hpp (lines 174 - 177)

Re: Review Request 56665: Added a URL-safe base64 implementation.

2017-02-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/ --- (Updated Feb. 16, 2017, 10:33 a.m.) Review request for mesos and Greg Mann.