Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/ --- (Updated March 6, 2017, 3:52 a.m.) Review request for mesos and Benjamin

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/#review167949 --- src/master/allocator/mesos/hierarchical.hpp Lines 518-528

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/ --- (Updated March 4, 2017, 7:36 p.m.) Review request for mesos and Benjamin

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/ --- (Updated March 4, 2017, 1:32 p.m.) Review request for mesos and Benjamin

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/ --- (Updated March 4, 2017, 11:47 a.m.) Review request for mesos and Benjamin

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

> On March 3, 2017, 5:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 458 (original), 463 (patched) > > > > > > Can you commit this separately? Committed separately here:

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/#review167928 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2017, 10:20

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

> On March 3, 2017, 5:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 429-432 (original), 394-400 (patched) > > > > > > Ditto from last review, could we simplify with a -

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

> On Feb. 27, 2017, 2:30 p.m., Michael Park wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1069 (patched) > > > > > > This is way more expensive than it needs to be. There's currently not a > >

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/#review167882 --- src/master/allocator/mesos/hierarchical.hpp Lines 426-429

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/#review166955 --- src/master/allocator/mesos/hierarchical.hpp (line 429)

Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627