Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review168844 --- src/tests/master_tests.cpp Lines 4369-4389 (patched)

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-13 Thread Benjamin Mahler
> On March 6, 2017, 10:38 p.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 4292-4293 (patched) > > > > > > Are you planning to test the agent endpoint as well? > > Jay Guo wrote: > I

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review168734 --- Patch looks great! Reviews applied: [57360, 57269] Passed

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-12 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- (Updated March 13, 2017, 10:43 a.m.) Review request for mesos and Benjamin

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- (Updated March 10, 2017, 10:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- (Updated March 9, 2017, 5:28 p.m.) Review request for mesos and Benjamin

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-06 Thread Jay Guo
> On March 7, 2017, 6:38 a.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 4292-4293 (patched) > > > > > > Are you planning to test the agent endpoint as well? I modified existing test to

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-06 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- (Updated March 7, 2017, 11:35 a.m.) Review request for mesos and Benjamin

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review168058 --- Looks good, just a few minor things and we can get this

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review167811 --- Patch looks great! Reviews applied: [57269] Passed command:

Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

2017-03-03 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7158