Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-28 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
---

(Updated March 28, 2017, 10:43 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.


Changes
---

Rebase, adam's comments.


Bugs: MESOS-7259
https://issues.apache.org/jira/browse/MESOS-7259


Repository: mesos


Description
---

The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.


Diffs (updated)
-

  CHANGELOG 875ae02008cb22515396cf17c1d2e7da0046d068 
  docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
  include/mesos/authorizer/acls.proto 46e66e8ed42240e5258890cdaf5aebe8800efcf0 
  src/authorizer/local/authorizer.cpp be8037299601427e5d5e79f58f77eea3f89579d0 
  src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
  src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
  src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f 
  src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 


Diff: https://reviews.apache.org/r/57472/diff/6/

Changes: https://reviews.apache.org/r/57472/diff/5-6/


Testing
---

`make check`


Thanks,

Alexander Rojas

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-28 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review170272
---


Fix it, then Ship it!




Minor clarification, otherwise great.


CHANGELOG
Lines 7-8 (patched)


This change is only applicable to the local authorizer, right? Other 
authorizers probably don't use `--acls`.


- Adam B


On March 21, 2017, 6:28 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> ---
> 
> (Updated March 21, 2017, 6:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.
> 
> 
> Bugs: MESOS-7259
> https://issues.apache.org/jira/browse/MESOS-7259
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 09fbf03b4274098e8051460bf9d7e9dac4acc987 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> e75e1879435f1c2bce47a86e9feebf9d051e969b 
>   src/authorizer/local/authorizer.cpp 
> be8037299601427e5d5e79f58f77eea3f89579d0 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/5/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-17 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
---

(Updated March 17, 2017, 12:09 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.


Changes
---

Rebased, AlexR review.


Bugs: MESOS-7259
https://issues.apache.org/jira/browse/MESOS-7259


Repository: mesos


Description
---

The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.


Diffs (updated)
-

  CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
  docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
  include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b 
  src/authorizer/local/authorizer.cpp be8037299601427e5d5e79f58f77eea3f89579d0 
  src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
  src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
  src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f 
  src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 


Diff: https://reviews.apache.org/r/57472/diff/4/

Changes: https://reviews.apache.org/r/57472/diff/3-4/


Testing
---

`make check`


Thanks,

Alexander Rojas

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-17 Thread Alexander Rojas 


> On March 13, 2017, 10:23 p.m., Alexander Rukletsov wrote:
> > docs/upgrades.md
> > Lines 261-263 (patched)
> > 
> >
> > Let's say how they should update the cluster.
> > 
> > ```
> > * When upgrading a Mesos cluster that uses the `set_quotas` or 
> > `remove_quotas` ACLs, the operator should first upgrade the Mesos binaries. 
> > At this point, the deprecated ACLs will still be enforced. After the 
> > upgrade has been verified, the operator should replace deprecated values 
> > for `set_quotas` and `remove_quotas` with equivalent values for 
> > `update_quotas`;
> > ```

Don't think we do that in the document. I can make a summary of what you said. 
However, don't you need to first upgrade the ACLs (we are deleting support from 
them) and then the binaries?


> On March 13, 2017, 10:23 p.m., Alexander Rukletsov wrote:
> > include/mesos/authorizer/acls.proto
> > Lines 406-409 (original)
> > 
> >
> > Do we usually keep a comment saying that tags `9` and `10` are not 
> > allowed to be used any more?

I don't think we do, but it does sound important.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168830
---


On March 13, 2017, 1:48 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> ---
> 
> (Updated March 13, 2017, 1:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 
> 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-13 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168830
---


Fix it, then Ship it!





CHANGELOG
Lines 5-9 (patched)


IIRC, we usually copy the ticket title first and then write a description 
if necessary. However, there is probably an even better solution. We've 
recently started to track deprecations in JIRA: 
https://issues.apache.org/jira/browse/MESOS-7134?jql=project%20%3D%20MESOS%20AND%20labels%20%3D%20deprecation

So how about creating a separate ticket for this patch?



docs/upgrades.md
Lines 261-263 (patched)


Let's say how they should update the cluster.

```
* When upgrading a Mesos cluster that uses the `set_quotas` or 
`remove_quotas` ACLs, the operator should first upgrade the Mesos binaries. At 
this point, the deprecated ACLs will still be enforced. After the upgrade has 
been verified, the operator should replace deprecated values for `set_quotas` 
and `remove_quotas` with equivalent values for `update_quotas`;
```



include/mesos/authorizer/acls.proto
Lines 406-409 (original)


Do we usually keep a comment saying that tags `9` and `10` are not allowed 
to be used any more?



src/master/master.hpp
Lines 1060-1064 (original), 1060-1064 (patched)


Kill the comment.


- Alexander Rukletsov


On March 13, 2017, 12:48 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> ---
> 
> (Updated March 13, 2017, 12:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 
> 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-13 Thread Alexander Rojas 


> On March 10, 2017, 9:50 a.m., Adam B wrote:
> > CHANGELOG
> > Lines 6 (patched)
> > 
> >
> > Please mention this in the docs/upgrades.md table as well.
> 
> Benjamin Bannier wrote:
> Did you forget to push the update fixing this?
> 
> Alexander Rojas wrote:
> What do you mean, it is in this patch.

https://reviews.apache.org/r/57472/diff/3#1


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
---


On March 10, 2017, 10:16 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> ---
> 
> (Updated March 10, 2017, 10:16 a.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 
> 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-13 Thread Alexander Rojas 


> On March 10, 2017, 9:50 a.m., Adam B wrote:
> > CHANGELOG
> > Lines 6 (patched)
> > 
> >
> > Please mention this in the docs/upgrades.md table as well.
> 
> Benjamin Bannier wrote:
> Did you forget to push the update fixing this?

What do you mean, it is in this patch.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
---


On March 10, 2017, 10:16 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> ---
> 
> (Updated March 10, 2017, 10:16 a.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 
> 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-10 Thread Benjamin Bannier 


> On March 10, 2017, 9:50 a.m., Adam B wrote:
> > CHANGELOG
> > Lines 6 (patched)
> > 
> >
> > Please mention this in the docs/upgrades.md table as well.

Did you forget to push the update fixing this?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
---


On March 10, 2017, 10:16 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> ---
> 
> (Updated March 10, 2017, 10:16 a.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 
> 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-10 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
---

(Updated March 10, 2017, 10:16 a.m.)


Review request for mesos, Adam B and Benjamin Bannier.


Changes
---

Adam's review.


Repository: mesos


Description
---

The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.


Diffs (updated)
-

  CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
  docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
  include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
  src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
  src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
  src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
  src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
  src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 


Diff: https://reviews.apache.org/r/57472/diff/3/

Changes: https://reviews.apache.org/r/57472/diff/2-3/


Testing
---

`make check`


Thanks,

Alexander Rojas

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-10 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168589
---



Thanks for taking this on. Besides a couple of doc updates, there's at least 
one more place to clean up:
https://github.com/apache/mesos/blob/1.2.0/src/master/master.hpp#L1036
```
// TODO(mpark): The following functions `authorizeSetQuota` and
// `authorizeRemoveQuota` should be replaced with `authorizeUpdateQuota` at
// the end of deprecation cycle which started with 1.0.`
```


CHANGELOG
Lines 1 (patched)


`Release Notes - Mesos - Version 1.3.0 (WIP)`



CHANGELOG
Lines 6 (patched)


Please mention this in the docs/upgrades.md table as well.


- Adam B


On March 10, 2017, 12:43 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> ---
> 
> (Updated March 10, 2017, 12:43 a.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   include/mesos/authorizer/acls.proto 
> 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 
> 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-10 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
---

(Updated March 10, 2017, 9:43 a.m.)


Review request for mesos, Adam B and Benjamin Bannier.


Changes
---

Rebased


Repository: mesos


Description
---

The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.


Diffs (updated)
-

  CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
  include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
  src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
  src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
  src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 


Diff: https://reviews.apache.org/r/57472/diff/2/

Changes: https://reviews.apache.org/r/57472/diff/1-2/


Testing
---

`make check`


Thanks,

Alexander Rojas

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-10 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
---

(Updated March 10, 2017, 9:18 a.m.)


Review request for mesos, Adam B and Benjamin Bannier.


Repository: mesos


Description
---

The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.


Diffs
-

  CHANGELOG c5eec5fcac58df2417922e4722238b9a2f321c76 
  include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
  src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
  src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
  src/tests/master_quota_tests.cpp 91219d6693fdd119ed3b0bf734eaa55da9c58b0a 


Diff: https://reviews.apache.org/r/57472/diff/1/


Testing
---

`make check`


Thanks,

Alexander Rojas

Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

2017-03-09 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/
---

Review request for mesos, Adam B and Benjamin Bannier.


Repository: mesos


Description
---

The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
more than six months ago, where they were replaced for the more
convenient `UpdateQuota` ACL. The deprecation cycle for these actions
is finally due while at the same time removing will make easier to
implement the hierarchical role feature in a generic way.


Diffs
-

  CHANGELOG c5eec5fcac58df2417922e4722238b9a2f321c76 
  include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
  src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
  src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
  src/tests/master_quota_tests.cpp 91219d6693fdd119ed3b0bf734eaa55da9c58b0a 


Diff: https://reviews.apache.org/r/57472/diff/1/


Testing
---

`make check`


Thanks,

Alexander Rojas