Re: Review Request 57762: Fixed environment duplication in command executor.

2017-03-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57762/#review169985 --- Patch looks great! Reviews applied: [57762] Passed command: expo

Re: Review Request 57762: Fixed environment duplication in command executor.

2017-03-23 Thread Alexander Rukletsov
> On March 24, 2017, 2:29 a.m., Adam B wrote: > > src/launcher/executor.cpp > > Lines 494 (patched) > > > > > > "Overwriting environment variable 'foo' with value from task > > environment." This is not necessarily

Re: Review Request 57762: Fixed environment duplication in command executor.

2017-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57762/#review169957 --- Ship it! Ship It! - Alexander Rukletsov On March 24, 2017, 2

Re: Review Request 57762: Fixed environment duplication in command executor.

2017-03-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57762/#review169955 --- Fix it, then Ship it! I've got some nits, but nothing major.

Re: Review Request 57762: Fixed environment duplication in command executor.

2017-03-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57762/ --- (Updated March 24, 2017, 2:24 a.m.) Review request for mesos, Adam B, Benjamin