Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-26 Thread Chun-Hung Hsiao
> On April 26, 2017, 7:16 p.m., Neil Conway wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 811 (patched) > > > > > > Wouldn't `path::join` be preferrable here? > > Chun-Hung Hsiao wrote:

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-26 Thread Neil Conway
> On April 26, 2017, 7:05 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 827 (patched) > > > > > > EXPECT_SOME > > Chun-Hung Hsiao wrote: > Should the `ASSERT_SOME` in

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-26 Thread Chun-Hung Hsiao
> On April 26, 2017, 7:05 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 827 (patched) > > > > > > EXPECT_SOME Should the `ASSERT_SOME` in Line 813 be changed to

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-26 Thread Chun-Hung Hsiao
> On April 26, 2017, 7:16 p.m., Neil Conway wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 811 (patched) > > > > > > Wouldn't `path::join` be preferrable here? Let me open a new PR to fix

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review173079 --- src/tests/containerizer/provisioner_docker_tests.cpp Lines 811

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review173078 --- Fix it, then Ship it!

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review172735 --- Patch looks great! Reviews applied: [58640] Passed command:

Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs: