Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review178133 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 349 (pat

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 16, 2017, 3:51 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 16, 2017, 3:29 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 16, 2017, 2:43 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review178074 --- include/mesos/mesos.proto Lines 356-357 (patched)

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review178073 --- Ship it! Modulo comments. - Benjamin Mahler On June 15, 2017

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review178072 --- include/mesos/mesos.proto Lines 980-982 (patched)

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-15 Thread Benjamin Mahler
> On June 15, 2017, 6:59 p.m., Neil Conway wrote: > > src/slave/constants.cpp > > Line 40 (original), 40 (patched) > > > > > > This should add `RESERVATION_REFINEMENT`. We try to add the agent capability after the ag

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review178027 --- include/mesos/mesos.proto Lines 347 (patched)

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 15, 2017, 12:37 a.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 14, 2017, 3:26 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 14, 2017, 3:21 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 14, 2017, 1:15 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 14, 2017, 1:06 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 13, 2017, 1:30 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-12 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review177538 --- include/mesos/mesos.proto Lines 347-354 (patched)

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review177145 --- Bad review! Reviews applied: [59861, 59860, 59859, 58510, 58509,

Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- Review request for mesos, Benjamin Mahler and Neil Conway. Bugs: MESOS-7575