Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review180073 --- Please comment with the result of a real reboot test. - Jiang

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review179817 --- Ship it! We'll need to document this behavior change in

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 29, 2017, 11:42 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 24, 2017, 6:19 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 6014 (patched) > > > > > > s/INFO/WARNING/. Changed to warning. I was debating earlier between warning and info and felt info

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 24, 2017, 6:19 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 6011-6020 (patched) > > > > > > Could you use the code in my comment: > > > > ``` > > if (!state->rebooted) { > >

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 29, 2017, 11:35 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178830 --- Fix it, then Ship it! src/slave/slave.cpp Lines 6011-6020

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 23, 2017, 11:21 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Line 6003 (original), 6007 (patched) > > > > > > Empty line above. > > Megha Sharma wrote: > This is not possible I guess, git

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 23, 2017, 6:21 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Line 6003 (original), 6007 (patched) > > > > > > Empty line above. This is not possible I guess, git pre-commit hook complains:

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 23, 2017, 9:30 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 23, 2017, 6:21 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5994-5999 (patched) > > > > > > I tweaked it a little bit: > > > > ``` > > // Fail the recovery unless the

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178750 --- src/slave/slave.cpp Lines 5980-5981 (original), 5980-5981

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5798-5867 (original), 5798-5867 (patched) > > > > > > So all of this work is only useful for recovering frameworks, it looks > >

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 23, 2017, 5:19 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > PTAL at these comments but I realize for this review it's probably easier > > if we sync on the high-level strategy first. Rearranged the code as per our discussion. - Megha ---

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 22, 2017, 11:38 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 22, 2017, 9:16 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5798-5867 (original), 5798-5867 (patched) > > > > > > So all of this work is only useful for recovering frameworks, it looks > >

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 21, 2017, 11:22 p.m.) Review request for mesos, Neil Conway,