Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 6, 2017, 10:44 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 6, 2017, 3:32 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 6, 2017, 3:27 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On July 6, 2017, 2:59 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 808 (patched) > > > > > > This line is longger than 80 chars: > > > > ``` > > Jies-MacBook-Pro:mesos

Re: Review Request 60280: Provide full path to the custom executor.

> On July 6, 2017, 2:59 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 808 (patched) > > > > > > This line is longger than 80 chars: > > > > ``` > > Jies-MacBook-Pro:mesos

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179745 --- This will break the windows build. os::which is only in posix

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179735 --- Bad patch! Reviews applied: [60280] Failed command: python

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 5, 2017, 9:03 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Re: Review Request 60280: Provide full path to the custom executor.

> On July 5, 2017, 4:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > This is still based on the assumption that `launchInfo` has > > `working_directory()`

Re: Review Request 60280: Provide full path to the custom executor.

> On July 5, 2017, 4:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > This is still based on the assumption that `launchInfo` has > > `working_directory()`

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179650 --- src/slave/containerizer/mesos/launch.cpp Lines 799 (patched)

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 6:35 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 4:18 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 4 p.m.) Review request for mesos, Jie Yu, James Peach,

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179433 --- src/slave/containerizer/mesos/launch.cpp Lines 799 (patched)

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178695 --- Patch looks great! Reviews applied: [60280] Passed command:

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated June 22, 2017, 3:20 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated June 22, 2017, 3:19 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 11:07 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 671-674 (patched) > > > > > > Sorry, I got confused. User should be the one setting argv[0]. So we > > don't need

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 11:07 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 671-674 (patched) > > > > > > Sorry, I got confused. User should be the one setting argv[0]. So we > > don't need

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178612 --- Patch looks great! Reviews applied: [60280] Passed command:

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178586 --- src/slave/containerizer/mesos/launch.cpp Lines 671-674 (patched)

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 9:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 801 (patched) > > > > > > Why this is necessary? I think execvp will look into the current > > working directory?

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated June 21, 2017, 10:26 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 7:28 p.m., Aaron Wood wrote: > > Someone correct me if I'm wrong, but I don't think we need this anymore: > > ``` > > if (launchInfo.has_working_directory()) { > > Try chdir = os::chdir(launchInfo.working_directory()); > > if (chdir.isError()) { > > cerr <<

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 9:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 801 (patched) > > > > > > Why this is necessary? I think execvp will look into the current > > working directory?

Re: Review Request 60280: Provide full path to the custom executor.

> On June 21, 2017, 7:28 p.m., Aaron Wood wrote: > > Someone correct me if I'm wrong, but I don't think we need this anymore: > > ``` > > if (launchInfo.has_working_directory()) { > > Try chdir = os::chdir(launchInfo.working_directory()); > > if (chdir.isError()) { > > cerr <<

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178562 --- src/slave/containerizer/mesos/launch.cpp Lines 671-674 (patched)

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178534 --- Someone correct me if I'm wrong, but I don't think we need this

Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- Review request for mesos, Jie Yu, James Peach, and Zhitao Li. Bugs: MESOS-7703