Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184325 --- Ship it! Ship It! - Gilbert Song On Aug. 30, 2017, 9:42 p.m.

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

> On Aug. 30, 2017, 5:14 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/future.hpp > > Lines 1702-1703 (patched) > > > > > > Let's stick to the `typename std::enable_if::type = 0` > > pattern for

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/ --- (Updated Aug. 31, 2017, 4:42 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184223 --- 3rdparty/libprocess/include/process/future.hpp Lines 1669-1670 (p

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184221 --- 3rdparty/libprocess/include/process/future.hpp Lines 1674 (patche

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

> On Aug. 30, 2017, 7:35 p.m., Jie Yu wrote: > > I got this compile error on my box: > > ```[jie@core-dev build]$ gcc -v > > Using built-in specs. > > COLLECT_GCC=/usr/bin/gcc > > COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper > > Target: x86_64-redhat-linux > > Config

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184185 --- I got this compile error on my box: ```[jie@core-dev build]$ gcc -

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184180 --- Ship it! This LGTM! Probably ask mpark to take a second look on

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

> On Aug. 30, 2017, 3:21 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/future.hpp > > Lines 1695-1696 (patched) > > > > > > IIUC, in this example, `undiscardable([]() { ...; })` lambda won't even > >

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184154 --- 3rdparty/libprocess/include/process/future.hpp Lines 1695-1696 (p

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184134 --- Bad patch! Reviews applied: [61987] Logs available here: http://

Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, and Jie Yu. Bugs: MESO