Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review190597 --- Ship it! Ship It! - Kevin Klues On Oct. 18, 2017, 9:23

Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review190595 --- support/mesos-style.py Lines 107 (patched)

Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review190593 --- Ship it! support/mesos-style.py Lines 99-111 (patched)

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review188477 --- PASS: Mesos patch 62214 was successfully built and tested.

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review188474 --- Patch looks great! Reviews applied: [62214] Passed command:

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review188466 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Oct. 18, 2017, 9:23 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187300 --- Patch looks great! Reviews applied: [62333, 62214] Passed

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187252 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187251 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Oct. 6, 2017, 9 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187214 --- Patch looks great! Reviews applied: [62333, 62214] Passed

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187180 --- support/mesos-style.py Lines 356-361 (patched)

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187178 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review187176 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62214: Added JavaScript linter.

2017-09-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186770 --- Patch looks great! Reviews applied: [62333, 62214] Passed

Re: Review Request 62214: Added JavaScript linter.

2017-09-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186679 --- PASS: Mesos patch 62214 was successfully built and tested.

Re: Review Request 62214: Added JavaScript linter.

2017-09-29 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 29, 2017, 1:28 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62214: Added JavaScript linter.

2017-09-27 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186407 --- src/webui/bootstrap Lines 71 (patched)

Re: Review Request 62214: Added JavaScript linter.

2017-09-25 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186138 --- PASS: Mesos patch 62214 was successfully built and tested.

Re: Review Request 62214: Added JavaScript linter.

2017-09-25 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 25, 2017, 2:56 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62214: Added JavaScript linter.

2017-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185677 --- Patch looks great! Reviews applied: [62333, 62214] Passed

Re: Review Request 62214: Added JavaScript linter.

2017-09-18 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 18, 2017, 3:10 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62214: Added JavaScript linter.

2017-09-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185507 --- Patch looks great! Reviews applied: [62332, 62333, 62214]

Re: Review Request 62214: Added JavaScript linter.

2017-09-15 Thread Armand Grillet
> On Sept. 11, 2017, 7:18 p.m., Benjamin Mahler wrote: > > support/mesos-style.py > > Lines 307-311 (patched) > > > > > > Similarly to my comment below, if we had some virtual env abstraction > > this could be

Re: Review Request 62214: Added JavaScript linter.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185453 --- FAIL: Some Mesos tests failed. Reviews applied: `['62332',

Re: Review Request 62214: Added JavaScript linter.

2017-09-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 14, 2017, 3:59 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185102 --- Can you add Kevin Klues to the review and ask him to take a look

Re: Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185080 --- FAIL: Some Mesos tests failed. Please check

Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7924