Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review189512 --- include/mesos/v1/resource_provider/resource_provider.proto Lines

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-27 Thread Chun-Hung Hsiao
> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 57-58 (patched) > > > > > > These two are not no needed for now. Let's remove it for now. Also,

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review189464 --- include/mesos/resource_provider/resource_provider.proto Lines 87

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-18 Thread Benjamin Bannier
> On Oct. 17, 2017, 10:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review188464 --- Bad patch! Reviews applied: [62502, 61947, 61946, 61810, 58021,

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-17 Thread Chun-Hung Hsiao
> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review188455 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-17 Thread Chun-Hung Hsiao
> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-17 Thread Chun-Hung Hsiao
> On Sept. 22, 2017, 7:05 p.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56 (patched) > > > > > > Can you elaborate the needs of `uuid` and `framework_id`? We need

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-17 Thread Chun-Hung Hsiao
> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review188386 --- include/mesos/resource_provider/resource_provider.proto Lines 38

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/ --- (Updated Oct. 13, 2017, 2:01 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/ --- (Updated Oct. 13, 2017, 1:20 p.m.) Review request for mesos, Benjamin Bannier,