Re: Review Request 62732: Added CMake documentation.

2017-10-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review187673 --- Ship it! Going to make some tweaks (rewording a couple

Re: Review Request 62732: Added CMake documentation.

2017-10-05 Thread Andrew Schwartzmeyer
> On Oct. 2, 2017, 3:26 p.m., Joseph Wu wrote: > > docs/cmake.md > > Lines 42 (patched) > > > > > > Hm... The website's markdown generator is not super sophisticated, so > > I'm not sure if it will render this link

Re: Review Request 62732: Added CMake documentation.

2017-10-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/ --- (Updated Oct. 5, 2017, noon) Review request for mesos, Benjamin Bannier, Jeff

Re: Review Request 62732: Added CMake documentation.

2017-10-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review187021 --- TODO: Add link to this to the general "Documentation" page. It's

Re: Review Request 62732: Added CMake documentation.

2017-10-03 Thread Andrew Schwartzmeyer
> On Oct. 2, 2017, 3:26 p.m., Joseph Wu wrote: > > docs/cmake-examples.md > > Lines 268 (patched) > > > > > > This should have been caught by the linter. Yeah... it should have, especially considering I wrote this

Re: Review Request 62732: Added CMake documentation.

2017-10-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review186899 --- Partial skim-review-thing... docs/cmake-examples.md Lines 268

Review Request 62732: Added CMake documentation.

2017-10-02 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/ --- Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John