Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

2017-11-15 Thread Greg Mann
> On Nov. 14, 2017, 10:12 p.m., Gaston Kleiman wrote: > > src/scheduler/scheduler.cpp > > Lines 123-124 (original), 123 (patched) > > > > > > For consistency I think that it'd also be nice to remove the `using > >

Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

2017-11-14 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/#review191007 --- Fix it, then Ship it! src/scheduler/scheduler.cpp Lines

Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

2017-11-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/ --- (Updated Nov. 14, 2017, 9:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

2017-11-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63768/ --- (Updated Nov. 14, 2017, 8:48 p.m.) Review request for mesos, Benjamin Bannier,