Re: Review Request 63861: Windows: Updated networking doc.

2018-01-17 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review195638
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Jan. 12, 2018, 6:35 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Jan. 12, 2018, 6:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-12 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Jan. 12, 2018, 2:35 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, John Kordich, and Michael Park.


Changes
---

Address Alex's feedback


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/9/

Changes: https://reviews.apache.org/r/63861/diff/8-9/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-11 Thread Akash Gupta 


> On Jan. 10, 2018, 12:32 p.m., Alexander Rukletsov wrote:
> > docs/networking.md
> > Lines 118-122 (patched)
> > 
> >
> > Can you please mention that other network modes than `NAT` and `USER` 
> > are not supported in Mesos?
> 
> Akash Gupta wrote:
> Could you elaborate what you mean by this? I already said that `HOST` is 
> unsupported on Windows, but `BRIDGE` (interpretted as `NAT`), `NONE` and 
> `USER` work on Windows.
> 
> Alexander Rukletsov wrote:
> From what I read in 
> https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/container-networking
>  there are other network modes that Mesos does not support.

Oh I see what you mean. The other network types are `USER`  networks that you 
need to manually create. For example, to use transparent, you need to do 
`docker network create -d transparent ` and then to launch a 
container, you do `docker run --network= ...`, so in Mesos, it 
would be a `USER` network with the name as ``. It's the same for 
`macvlan` and `overlay` on Linux as well. I'll add some clarification on this.


- Akash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review195131
---


On Jan. 10, 2018, 1:42 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Jan. 10, 2018, 1:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-11 Thread Alexander Rukletsov 


> On Jan. 10, 2018, 12:32 p.m., Alexander Rukletsov wrote:
> > docs/networking.md
> > Lines 118-122 (patched)
> > 
> >
> > Can you please mention that other network modes than `NAT` and `USER` 
> > are not supported in Mesos?
> 
> Akash Gupta wrote:
> Could you elaborate what you mean by this? I already said that `HOST` is 
> unsupported on Windows, but `BRIDGE` (interpretted as `NAT`), `NONE` and 
> `USER` work on Windows.

>From what I read in 
>https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/container-networking
> there are other network modes that Mesos does not support.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review195131
---


On Jan. 10, 2018, 1:42 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Jan. 10, 2018, 1:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-10 Thread Akash Gupta 


> On Jan. 10, 2018, 12:32 p.m., Alexander Rukletsov wrote:
> > docs/networking.md
> > Lines 118-122 (patched)
> > 
> >
> > Can you please mention that other network modes than `NAT` and `USER` 
> > are not supported in Mesos?

Could you elaborate what you mean by this? I already said that `HOST` is 
unsupported on Windows, but `BRIDGE` (interpretted as `NAT`), `NONE` and `USER` 
work on Windows.


> On Jan. 10, 2018, 12:32 p.m., Alexander Rukletsov wrote:
> > docs/networking.md
> > Line 118 (original), 121-123 (patched)
> > 
> >
> > I'm not sure this is true with our proto having a default value. Can 
> > you please verify that?

In the docker and health check tests, the tests work even if I don't specify 
`containerInfo.mutable_docker()->set_network()`. If the default was being set 
to `HOST` on Windows, then it should have errored out. So, it looks like the 
right default (`NAT/BRIDGE`) is being picked up on the receiver side. However, 
I'm not sure how marathon or other frameworks encode the default protobuf value.


- Akash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review195131
---


On Jan. 10, 2018, 1:42 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Jan. 10, 2018, 1:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-10 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review195131
---


Fix it, then Ship it!





docs/networking.md
Lines 118-122 (patched)


Can you please mention that other network modes than `NAT` and `USER` are 
not supported in Mesos?



docs/networking.md
Line 118 (original), 121-123 (patched)


I'm not sure this is true with our proto having a default value. Can you 
please verify that?


- Alexander Rukletsov


On Jan. 10, 2018, 1:42 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Jan. 10, 2018, 1:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-09 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Jan. 10, 2018, 1:42 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, John Kordich, and Michael Park.


Changes
---

Rebased with gaston's feedback


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/8/

Changes: https://reviews.apache.org/r/63861/diff/7-8/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-08 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review194989
---


Fix it, then Ship it!





docs/networking.md
Lines 118 (patched)


Nit: s/the `HOST` network/the `HOST` network mode/



docs/networking.md
Lines 121 (patched)


s/If the network is not specified/If the network mode is not specified/
s/the default the default network/the default mode/


- Gaston Kleiman


On Jan. 5, 2018, 10:32 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Jan. 5, 2018, 10:32 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, John Kordich, and Michael Park.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/7/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-05 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Jan. 5, 2018, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, John Kordich, and Michael Park.


Changes
---

Updated to reflect networking changes.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/7/

Changes: https://reviews.apache.org/r/63861/diff/6-7/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 63861: Windows: Updated networking doc.

2018-01-04 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Jan. 5, 2018, 12:29 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, John Kordich, and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/6/

Changes: https://reviews.apache.org/r/63861/diff/5-6/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 63861: Windows: Updated networking doc.

2017-12-07 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Dec. 7, 2017, 10:05 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Changes
---

fixed typo


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/5/

Changes: https://reviews.apache.org/r/63861/diff/4-5/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 63861: Windows: Updated networking doc.

2017-12-07 Thread Akash Gupta 


> On Dec. 7, 2017, 9:41 p.m., Andrew Schwartzmeyer wrote:
> > docs/networking.md
> > Lines 120 (patched)
> > 
> >
> > nit: s/is/are

fixed


- Akash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review193174
---


On Dec. 7, 2017, 10:05 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Dec. 7, 2017, 10:05 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2017-12-07 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review193174
---




docs/networking.md
Lines 120 (patched)


nit: s/is/are


- Andrew Schwartzmeyer


On Dec. 7, 2017, 4:05 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> ---
> 
> (Updated Dec. 7, 2017, 4:05 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
> 
> 
> Diffs
> -
> 
>   docs/networking.md bdd3a762435aae163fc659ccfea7da825983 
> 
> 
> Diff: https://reviews.apache.org/r/63861/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 63861: Windows: Updated networking doc.

2017-12-07 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Dec. 7, 2017, 12:05 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Changes
---

Rebased.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/4/

Changes: https://reviews.apache.org/r/63861/diff/3-4/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 63861: Windows: Updated networking doc.

2017-11-27 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Nov. 27, 2017, 5:38 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Changes
---

Rebased and changed host mode to nat mode on Windows


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/3/

Changes: https://reviews.apache.org/r/63861/diff/2-3/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 63861: Windows: Updated networking doc.

2017-11-17 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
---

(Updated Nov. 17, 2017, 10:38 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Summary (updated)
-

Windows: Updated networking doc.


Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342


Repository: mesos


Description (updated)
---

The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.


Diffs (updated)
-

  docs/networking.md bdd3a762435aae163fc659ccfea7da825983 


Diff: https://reviews.apache.org/r/63861/diff/2/

Changes: https://reviews.apache.org/r/63861/diff/1-2/


Testing
---


Thanks,

Akash Gupta