Re: Review Request 63914: Changed agent reregistration to work with message directly.

2017-12-06 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/ --- (Updated Dec. 6, 2017, 4:24 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 63914: Changed agent reregistration to work with message directly.

2017-12-05 Thread Dmitry Zhuk
> On Dec. 4, 2017, 9:18 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 6492-6499 (patched) > > > > > > Hm.. I'm curious if you have any thoughts on avoiding copying it out of > > the message. We c

Re: Review Request 63914: Changed agent reregistration to work with message directly.

2017-12-05 Thread Dmitry Zhuk
> On Dec. 4, 2017, 5:57 p.m., Michael Park wrote: > > src/master/master.cpp > > Line 6433 (original), 6394 (patched) > > > > > > I think these `message` to `message_` changes should either take the > > type of the

Re: Review Request 63914: Changed agent reregistration to work with message directly.

2017-12-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/#review192747 --- Ship it! Exciting to see this stuff come together! Looks good,

Re: Review Request 63914: Changed agent reregistration to work with message directly.

2017-12-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/#review192721 --- Fix it, then Ship it! src/master/master.cpp Line 6433 (origina

Re: Review Request 63914: Changed agent reregistration to work with message directly.

2017-11-21 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/ --- (Updated Nov. 21, 2017, 5:53 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 63914: Changed agent reregistration to work with message directly.

2017-11-17 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972