Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-05 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 5, 2017, 9:25 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192911 --- Ship it! Ship It! - Vinod Kone On Dec. 5, 2017, 7:03 p.m., B

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-05 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 5, 2017, 7:03 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192905 --- Fix it, then Ship it! src/tests/hierarchical_allocator_tests.c

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-05 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 5, 2017, 4:14 p.m.) Review request for mesos and Vinod Kone. Re

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-04 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 4, 2017, 11:43 p.m.) Review request for mesos and Vinod Kone. R

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-04 Thread Benno Evers
> On Dec. 4, 2017, 10:05 p.m., Vinod Kone wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 6338 (patched) > > > > > > I wonder what caused the allocation to happen given you didn't set > > `updated`

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192773 --- src/master/allocator/mesos/hierarchical.cpp Lines 612 (patched) <

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-04 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 4, 2017, 4:30 p.m.) Review request for mesos and Vinod Kone. Re

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192535 --- src/master/master.cpp Lines 6923-6927 (original), 6894-6898 (patc

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-01 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 1, 2017, 6:31 p.m.) Review request for mesos and Vinod Kone. Re

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192157 --- Ship it! Ship It! - Vinod Kone On Nov. 29, 2017, 6:27 p.m.,

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192151 --- src/master/master.cpp Lines 6913 (patched)

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
> On Nov. 23, 2017, 12:52 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Line 6672 (original), 6609 (patched) > > > > > > Reject if agent is being marked gone or already marked gone. Can you do > > this and

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
> On Nov. 23, 2017, 12:52 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 6323 (patched) > > > > > > Can you file a JIRA for this? https://issues.apache.org/jira/browse/MESOS-8273 - Benno --

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Nov. 29, 2017, 6:27 p.m.) Review request for mesos and Vinod Kone. R

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review191958 --- src/master/master.cpp Lines 6879 (patched)

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Nov. 28, 2017, 12:28 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Nov. 27, 2017, 11:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review191767 --- src/master/master.hpp Lines 1105 (patched)

Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --