Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-03-01 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review198474 --- There is still one issue with this patch, I have seen some

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-02-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review198171 --- Patch looks great! Reviews applied: [64970] Passed command:

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-02-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review198169 --- PASS: Mesos patch 64970 was successfully built and tested.

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-02-22 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated Feb. 23, 2018, 7:58 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-01-18 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated Jan. 18, 2018, 11:46 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-01-18 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated Jan. 18, 2018, 11:20 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-01-05 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review194853 --- I agree with Kevin, hhaving tox managing our virtualenvs rather

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-01-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review194848 --- Is the assumption that the user already have `tox` installed on

Review Request 64970: Replace ad hoc venv under support/ with tox.

2018-01-05 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- Review request for mesos, Armand Grillet and Kevin Klues. Repository: mesos