Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID.

2018-01-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/#review195338
---


Fix it, then Ship it!





src/master/master.cpp
Lines 10339 (patched)


Nit: s/operation/operator/

I can fix this while committing.


- Greg Mann


On Jan. 12, 2018, 12:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65096/
> ---
> 
> (Updated Jan. 12, 2018, 12:49 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-8422
> https://issues.apache.org/jira/browse/MESOS-8422
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes logging of master's `updateOperation` for operations
> without framework ID. We also add a `CHECK` before the part updating
> resources or the allocator for non-speculated operations; currently
> non-speculated operations can only be initiated from a framework, but
> not from e.g., the operation API, and additional work is needed to
> support this.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 
> 
> 
> Diff: https://reviews.apache.org/r/65096/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID.

2018-01-12 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/
---

(Updated Jan. 12, 2018, 1:49 p.m.)


Review request for mesos and Jan Schlicht.


Changes
---

Addressed comment from Jan.


Bugs: MESOS-8422
https://issues.apache.org/jira/browse/MESOS-8422


Repository: mesos


Description
---

This patch fixes logging of master's `updateOperation` for operations
without framework ID. We also add a `CHECK` before the part updating
resources or the allocator for non-speculated operations; currently
non-speculated operations can only be initiated from a framework, but
not from e.g., the operation API, and additional work is needed to
support this.


Diffs (updated)
-

  src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 


Diff: https://reviews.apache.org/r/65096/diff/3/

Changes: https://reviews.apache.org/r/65096/diff/2-3/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID.

2018-01-12 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/#review195304
---


Fix it, then Ship it!





src/master/master.cpp
Lines 10306 (patched)


Let's not use an empty string but " of a operator API call" here, as it's 
done in `Master::updateOperationStatus`.


- Jan Schlicht


On Jan. 12, 2018, 11:53 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65096/
> ---
> 
> (Updated Jan. 12, 2018, 11:53 a.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-8422
> https://issues.apache.org/jira/browse/MESOS-8422
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes logging of master's `updateOperation` for operations
> without framework ID. We also add a `CHECK` before the part updating
> resources or the allocator for non-speculated operations; currently
> non-speculated operations can only be initiated from a framework, but
> not from e.g., the operation API, and additional work is needed to
> support this.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 
> 
> 
> Diff: https://reviews.apache.org/r/65096/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID.

2018-01-12 Thread Benjamin Bannier 


> On Jan. 11, 2018, 10:22 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 10343-10344 (patched)
> > 
> >
> > What about speculative operations initiated via the operator API on 
> > resources offered by resource-provider-capable agents? I think we would hit 
> > this CHECK in that case?

Good catch.

I now preventing outputing a default `framework_id` value in the logging and 
moved the `CHECK` below the early exit for speculated operations.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/#review195253
---


On Jan. 12, 2018, 11:53 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65096/
> ---
> 
> (Updated Jan. 12, 2018, 11:53 a.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-8422
> https://issues.apache.org/jira/browse/MESOS-8422
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes logging of master's `updateOperation` for operations
> without framework ID. We also add a `CHECK` before the part updating
> resources or the allocator for non-speculated operations; currently
> non-speculated operations can only be initiated from a framework, but
> not from e.g., the operation API, and additional work is needed to
> support this.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 
> 
> 
> Diff: https://reviews.apache.org/r/65096/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID.

2018-01-12 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65096/
---

(Updated Jan. 12, 2018, 11:53 a.m.)


Review request for mesos and Jan Schlicht.


Changes
---

Addressed issue identified by Greg.


Summary (updated)
-

Fixed master's `updateOperation` for operations without framework ID.


Bugs: MESOS-8422
https://issues.apache.org/jira/browse/MESOS-8422


Repository: mesos


Description (updated)
---

This patch fixes logging of master's `updateOperation` for operations
without framework ID. We also add a `CHECK` before the part updating
resources or the allocator for non-speculated operations; currently
non-speculated operations can only be initiated from a framework, but
not from e.g., the operation API, and additional work is needed to
support this.


Diffs (updated)
-

  src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab 


Diff: https://reviews.apache.org/r/65096/diff/2/

Changes: https://reviews.apache.org/r/65096/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier