Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-16 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/
---

(Updated Jan. 16, 2018, 1:26 p.m.)


Review request for mesos, Akash Gupta, Gilbert Song, Jie Yu, and Joseph Wu.


Bugs: MESOS-8443
https://issues.apache.org/jira/browse/MESOS-8443


Repository: mesos


Description
---

The `docker` executable is not usually installed in
`os::host_default_path()` on Windows, so the Executor cannot find it.
Now, before launching the Executor, the Agent finds the directory
containing `docker` and prepends it to the `PATH` given to the Executor
so that both the Executor and Agent use the same `docker`.


Diffs
-

  src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 


Diff: https://reviews.apache.org/r/65147/diff/2/


Testing
---

Tested on Windows 10, all passed.

Integration tested (courtsey of Akash) that Docker containers can be launched 
without manually fixing the path.

`make check` on CentOS 7, all passed.

NOTE: This is Windows-only, and replaces 
[#64570](https://reviews.apache.org/r/64570/). Joseph and I worked out this 
approach to prevent a regression for Mesos customers moving from `1.4` to 
`1.5`; see MESOS-8443 for details.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/#review195501
---



FAIL: Some Mesos tests failed.

Reviews applied: `['65144', '65145', '65146', '65147']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (75 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2455 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2479 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2485 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2509 ms total)

[--] Global test environment tear-down
[==] 856 tests from 86 test cases ran. (310574 ms total)
[  PASSED  ] 849 tests.
[  FAILED  ] 7 tests, listed below:
[  FAILED  ] 
HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPWithContainerImage
[  FAILED  ] 
HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPSWithContainerImage
[  FAILED  ] 
HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaTCPWithContainerImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 7 FAILED TESTS
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stderr.log):

```
I0116 21:01:23.753518  7344 master.cpp:10161] Updating the state of task 
d79e4bfc-1327-44be-a903-6a23a61b6c77 of framework 
d04c0420-41f7-4470-b2db-080d3af9a5c2- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0116 21:01:23.753518  2848 slave.cpp:3388] Shutting down fI0116 
21:01:23.050737  8984 exec.cpp:162] Version: 1.6.0
I0116 21:01:23.075409  3712 exec.cpp:236] Executor registered on agent 
d04c0420-41f7-4470-b2db-080d3af9a5c2-S0
I0116 21:01:23.078408 13928 executor.cpp:171] Received SUBSCRIBED event
I0116 21:01:23.082614 13928 executor.cpp:175] Subscribed executor on 
build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0116 21:01:23.083410 13928 executor.cpp:171] Received LAUNCH event
I0116 21:01:23.086410 13928 executor.cpp:638] Starting task 
d79e4bfc-1327-44be-a903-6a23a61b6c77
I0116 21:01:23.168426 13928 executor.cpp:478] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0116 21:01:23.724514 13928 executor.cpp:651] Forked command at 5092
I0116 21:01:23.755515  9396 exec.cpp:445] Executor asked to shutdown
I0116 21:01:23.756518 13928 executor.cpp:171] Received SHUTDOWN event
I0116 21:01:23.756518 13928 executor.cpp:748] Shutting down
I0116 21:01:23.756518 13928 executor.cpp:863] Sending SIGTERM to process tree 
at pid 5ramework d04c0420-41f7-4470-b2db-080d3af9a5c2-
I0116 21:01:23.754518  2848 slave.cpp:6066] Shutting down executor 
'd79e4bfc-1327-44be-a903-6a23a61b6c77' of framework 
d04c0420-41f7-4470-b2db-080d3af9a5c2- at executor(1)@10.3.1.11:56764
I0116 21:01:23.754518  2848 slave.cpp:931] Agent terminating
W0116 21:01:23.755515  2848 slave.cpp:3384] Ignoring shutdown framework 
d04c0420-41f7-4470-b2db-080d3af9a5c2- because it is terminating
I0116 21:01:23.755515  7344 master.cpp:10265] Removing task 
d79e4bfc-1327-44be-a903-6a23a61b6c77 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework d04c0420-41f7-4470-b2db-080d3af9a5c2- on 
agent d04c0420-41f7-4470-b2db-080d3af9a5c2-S0 at slave(329)@10.3.1.11:56743 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0116 21:01:23.758515  7344 master.cpp:1306] Agent 
d04c0420-41f7-4470-b2db-080d3af9a5c2-S0 at slave(329)@10.3.1.11:56743 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0116 21:01:23.758515  2848 containerizer.cpp:2352] Destroying container 
9292b270-408c-4e30-aeba-2359c4d52b00 in RUNNING state
I0116 21:01:23.758515  7344 master.cpp:3287] Disconnecting agent 
d04c0420-41f7-4470-b2db-080d3af9a5c2-S0 at slave(329)@10.3.1.11:56743 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0116

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-16 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/
---

(Updated Jan. 16, 2018, 12:05 p.m.)


Review request for mesos, Akash Gupta, Gilbert Song, Jie Yu, and Joseph Wu.


Bugs: MESOS-8443
https://issues.apache.org/jira/browse/MESOS-8443


Repository: mesos


Description (updated)
---

The `docker` executable is not usually installed in
`os::host_default_path()` on Windows, so the Executor cannot find it.
Now, before launching the Executor, the Agent finds the directory
containing `docker` and prepends it to the `PATH` given to the Executor
so that both the Executor and Agent use the same `docker`.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 


Diff: https://reviews.apache.org/r/65147/diff/2/

Changes: https://reviews.apache.org/r/65147/diff/1-2/


Testing
---

Tested on Windows 10, all passed.

Integration tested (courtsey of Akash) that Docker containers can be launched 
without manually fixing the path.

`make check` on CentOS 7, all passed.

NOTE: This is Windows-only, and replaces 
[#64570](https://reviews.apache.org/r/64570/). Joseph and I worked out this 
approach to prevent a regression for Mesos customers moving from `1.4` to 
`1.5`; see MESOS-8443 for details.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-16 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/#review195492
---


Fix it, then Ship it!





src/slave/containerizer/docker.cpp
Lines 1470-1471 (patched)


We will consider removing the `#ifdef` in future, as other platforms may 
benefit from being pointed to the same `docker` in both Agent and Executor 
(there is a chance that the cleaned path results in using a different `docker`, 
if multiple `docker`s are installed).



src/slave/containerizer/docker.cpp
Lines 1477 (patched)


On the off-chance that `docker` is installed in the `host_default_path()`, 
this `PATH` modification should **pre**-pend the docker path, rather than 
append it.


- Joseph Wu


On Jan. 13, 2018, 6:01 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65147/
> ---
> 
> (Updated Jan. 13, 2018, 6:01 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Gilbert Song, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8443
> https://issues.apache.org/jira/browse/MESOS-8443
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `docker` isn't always installed in `os::host_default_path()` on Windows,
> so the docker executor cannot find it. Now, before launching the
> executor, the mesos agent finds `docker`'s parent directory and appends
> that to `PATH`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 
> 
> 
> Diff: https://reviews.apache.org/r/65147/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on Windows 10, all passed.
> 
> Integration tested (courtsey of Akash) that Docker containers can be launched 
> without manually fixing the path.
> 
> `make check` on CentOS 7, all passed.
> 
> NOTE: This is Windows-only, and replaces 
> [#64570](https://reviews.apache.org/r/64570/). Joseph and I worked out this 
> approach to prevent a regression for Mesos customers moving from `1.4` to 
> `1.5`; see MESOS-8443 for details.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/#review195389
---



PASS: Mesos patch 65147 was successfully built and tested.

Reviews applied: `['65144', '65145', '65147']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147

- Mesos Reviewbot Windows


On Jan. 12, 2018, 10:31 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65147/
> ---
> 
> (Updated Jan. 12, 2018, 10:31 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8443
> https://issues.apache.org/jira/browse/MESOS-8443
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `docker` isn't always installed in `os::host_default_path()` on Windows,
> so the docker executor cannot find it. Now, before launching the
> executor, the mesos agent finds `docker`'s parent directory and appends
> that to `PATH`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 
> 
> 
> Diff: https://reviews.apache.org/r/65147/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on Windows 10, all passed.
> 
> Integration tested (courtsey of Akash) that Docker containers can be launched 
> without manually fixing the path.
> 
> `make check` on CentOS 7, all passed.
> 
> NOTE: This is Windows-only, and replaces 
> [#64570](https://reviews.apache.org/r/64570/). Joseph and I worked out this 
> approach to prevent a regression for Mesos customers moving from `1.4` to 
> `1.5`; see MESOS-8443 for details.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-12 Thread Andrew Schwartzmeyer 


> On Jan. 12, 2018, 6:51 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some Mesos tests failed.
> > 
> > Reviews applied: `['65144', '65145', '65146', '65147']`
> > 
> > Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147
> > 
> > Relevant logs:
> > 
> > - 
> > [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stdout.log):
> > 
> > ```
> > [ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
> > [   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 
> > (36 ms)
> > [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (68 
> > ms total)
> > 
> > [--] 1 test from IsolationFlag/CpuIsolatorTest
> > [ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
> > [   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2481 ms)
> > [--] 1 test from IsolationFlag/CpuIsolatorTest (2505 ms total)
> > 
> > [--] 1 test from IsolationFlag/MemoryIsolatorTest
> > [ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
> > [   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2379 ms)
> > [--] 1 test from IsolationFlag/MemoryIsolatorTest (2402 ms total)
> > 
> > [--] Global test environment tear-down
> > [==] 856 tests from 86 test cases ran. (309199 ms total)
> > [  PASSED  ] 849 tests.
> > [  FAILED  ] 7 tests, listed below:
> > [  FAILED  ] 
> > HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPWithContainerImage
> > [  FAILED  ] 
> > HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPSWithContainerImage
> > [  FAILED  ] 
> > HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaTCPWithContainerImage
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
> > [  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
> > 
> >  7 FAILED TESTS
> >   YOU HAVE 214 DISABLED TESTS
> > 
> > ```
> > 
> > - 
> > [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stderr.log):
> > 
> > ```
> > I0113 02:51:12.640440 10348 slave.cpp:3388] Shutting down frameI0113 
> > 02:51:11.954365  5936 exec.cpp:162] Version: 1.6.0
> > I0113 02:51:11.985371 15076 exec.cpp:236] Executor registered on agent 
> > e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
> > I0113 02:51:11.988370 13828 executor.cpp:171] Received SUBSCRIBED event
> > I0113 02:51:11.993367 13828 executor.cpp:175] Subscribed executor on 
> > build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
> > I0113 02:51:11.993367 13828 executor.cpp:171] Received LAUNCH event
> > I0113 02:51:11.997367 13828 executor.cpp:638] Starting task 
> > ca210858-1bd1-442c-9903-2675f2028a00
> > I0113 02:51:12.076376 13828 executor.cpp:478] Running 
> > 'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
> > I0113 02:51:12.616439 13828 executor.cpp:651] Forked command at 10492
> > I0113 02:51:12.642441 10516 exec.cpp:445] Executor asked to shutdown
> > I0113 02:51:12.643440 13828 executor.cpp:171] Received SHUTDOWN event
> > I0113 02:51:12.643440 13828 executor.cpp:748] Shutting down
> > I0113 02:51:12.643440 13828 executor.cpp:863] Sending SIGTERM to process 
> > tree at pid work e7aa8781-54a9-412d-bea4-00dcd5b00201-
> > I0113 02:51:12.640440  1248 master.cpp:10161] Updating the state of task 
> > ca210858-1bd1-442c-9903-2675f2028a00 of framework 
> > e7aa8781-54a9-412d-bea4-00dcd5b00201- (latest state: TASK_KILLED, 
> > status update state: TASK_KILLED)
> > I0113 02:51:12.641441 10348 slave.cpp:6066] Shutting down executor 
> > 'ca210858-1bd1-442c-9903-2675f2028a00' of framework 
> > e7aa8781-54a9-412d-bea4-00dcd5b00201- at executor(1)@10.3.1.11:50065
> > I0113 02:51:12.642441 10348 slave.cpp:931] Agent terminating
> > W0113 02:51:12.642441 10348 slave.cpp:3384] Ignoring shutdown framework 
> > e7aa8781-54a9-412d-bea4-00dcd5b00201- because it is terminating
> > I0113 02:51:12.643440  1248 master.cpp:10265] Removing task 
> > ca210858-1bd1-442c-9903-2675f2028a00 with resources cpus(allocated: *):4; 
> > mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
> > *):[31000-32000] of framework e7aa8781-54a9-412d-bea4-00dcd5b00201- on 
> > agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0 at slave(329)@10.3.1.11:50044 
> > (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0113 02:51:12.645442 10348 containerizer.cpp:2352] Destroying container 
> > 5e1f835c-6470-42e4-98cb-6a4beaf21b3b in RUNNING state
> > I0113 02:51:12.645442 10348 containerizer.cpp:2966] Transitioning the state 
> > of container 5e1f835c-6470-42e4-98cb-6a4beaf21b3b from RUNNING to DESTROYING
> > I0113 02:51:12.646443  1248 master.cpp:1306] Agent 
> >

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-12 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/
---

(Updated Jan. 12, 2018, 10:31 p.m.)


Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Changes
---

Skip the enable `INTERNET` filter tests because they fail on the bot, and 
aren't necessary.


Bugs: MESOS-8443
https://issues.apache.org/jira/browse/MESOS-8443


Repository: mesos


Description
---

`docker` isn't always installed in `os::host_default_path()` on Windows,
so the docker executor cannot find it. Now, before launching the
executor, the mesos agent finds `docker`'s parent directory and appends
that to `PATH`.


Diffs
-

  src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 


Diff: https://reviews.apache.org/r/65147/diff/1/


Testing
---

Tested on Windows 10, all passed.

Integration tested (courtsey of Akash) that Docker containers can be launched 
without manually fixing the path.

`make check` on CentOS 7, all passed.

NOTE: This is Windows-only, and replaces 
[#64570](https://reviews.apache.org/r/64570/). Joseph and I worked out this 
approach to prevent a regression for Mesos customers moving from `1.4` to 
`1.5`; see MESOS-8443 for details.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/#review195383
---



FAIL: Some Mesos tests failed.

Reviews applied: `['65144', '65145', '65146', '65147']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (68 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2481 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2505 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2379 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2402 ms total)

[--] Global test environment tear-down
[==] 856 tests from 86 test cases ran. (309199 ms total)
[  PASSED  ] 849 tests.
[  FAILED  ] 7 tests, listed below:
[  FAILED  ] 
HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPWithContainerImage
[  FAILED  ] 
HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPSWithContainerImage
[  FAILED  ] 
HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaTCPWithContainerImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 7 FAILED TESTS
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65147/logs/mesos-tests-stderr.log):

```
I0113 02:51:12.640440 10348 slave.cpp:3388] Shutting down frameI0113 
02:51:11.954365  5936 exec.cpp:162] Version: 1.6.0
I0113 02:51:11.985371 15076 exec.cpp:236] Executor registered on agent 
e7aa8781-54a9-412d-bea4-00dcd5b00201-S0
I0113 02:51:11.988370 13828 executor.cpp:171] Received SUBSCRIBED event
I0113 02:51:11.993367 13828 executor.cpp:175] Subscribed executor on 
build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0113 02:51:11.993367 13828 executor.cpp:171] Received LAUNCH event
I0113 02:51:11.997367 13828 executor.cpp:638] Starting task 
ca210858-1bd1-442c-9903-2675f2028a00
I0113 02:51:12.076376 13828 executor.cpp:478] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0113 02:51:12.616439 13828 executor.cpp:651] Forked command at 10492
I0113 02:51:12.642441 10516 exec.cpp:445] Executor asked to shutdown
I0113 02:51:12.643440 13828 executor.cpp:171] Received SHUTDOWN event
I0113 02:51:12.643440 13828 executor.cpp:748] Shutting down
I0113 02:51:12.643440 13828 executor.cpp:863] Sending SIGTERM to process tree 
at pid work e7aa8781-54a9-412d-bea4-00dcd5b00201-
I0113 02:51:12.640440  1248 master.cpp:10161] Updating the state of task 
ca210858-1bd1-442c-9903-2675f2028a00 of framework 
e7aa8781-54a9-412d-bea4-00dcd5b00201- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0113 02:51:12.641441 10348 slave.cpp:6066] Shutting down executor 
'ca210858-1bd1-442c-9903-2675f2028a00' of framework 
e7aa8781-54a9-412d-bea4-00dcd5b00201- at executor(1)@10.3.1.11:50065
I0113 02:51:12.642441 10348 slave.cpp:931] Agent terminating
W0113 02:51:12.642441 10348 slave.cpp:3384] Ignoring shutdown framework 
e7aa8781-54a9-412d-bea4-00dcd5b00201- because it is terminating
I0113 02:51:12.643440  1248 master.cpp:10265] Removing task 
ca210858-1bd1-442c-9903-2675f2028a00 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework e7aa8781-54a9-412d-bea4-00dcd5b00201- on 
agent e7aa8781-54a9-412d-bea4-00dcd5b00201-S0 at slave(329)@10.3.1.11:50044 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0113 02:51:12.645442 10348 containerizer.cpp:2352] Destroying container 
5e1f835c-6470-42e4-98cb-6a4beaf21b3b in RUNNING state
I0113 02:51:12.645442 10348 containerizer.cpp:2966] Transitioning the state of 
container 5e1f835c-6470-42e4-98cb-6a4beaf21b3b from RUNNING to DESTROYING
I0113 02:51:12.646443  1248 master.cpp:1306] Agent 
e7aa8781-54a9-412d-bea4-00dcd5b00201-S0 at slave(329)@10.3.1.11:50044 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0113 02:51:12.646443  1248 master.cpp:3287] Disconnecting agent

Review Request 65147: Windows: Fixed docker executor `PATH` variable.

2018-01-12 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/
---

Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Bugs: MESOS-8443
https://issues.apache.org/jira/browse/MESOS-8443


Repository: mesos


Description
---

`docker` isn't always installed in `os::host_default_path()` on Windows,
so the docker executor cannot find it. Now, before launching the
executor, the mesos agent finds `docker`'s parent directory and appends
that to `PATH`.


Diffs
-

  src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb 


Diff: https://reviews.apache.org/r/65147/diff/1/


Testing
---

Tested on Windows 10, all passed.

Integration tested (courtsey of Akash) that Docker containers can be launched 
without manually fixing the path.

`make check` on CentOS 7 (results pending, prior build with `os::which` changes 
passed tests)


Thanks,

Andrew Schwartzmeyer