Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-03-22 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/
---

(Updated March 22, 2018, 11:25 a.m.)


Review request for mesos, Greg Mann and Zhitao Li.


Changes
---

Rebased.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added master metrics for operation status acknowledgments handling.


Diffs (updated)
-

  docs/monitoring.md 5c71cc9f39743003bd4eae0244f5d5e95beff591 
  src/master/metrics.hpp b343904bd99defffe098077855d686b2d33c1fc1 
  src/master/metrics.cpp b627372fd09b84aeda0b8e1b209d3bc0547faa39 


Diff: https://reviews.apache.org/r/65300/diff/7/

Changes: https://reviews.apache.org/r/65300/diff/6-7/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-03-20 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/#review199587
---


Ship it!




Ship It!

- Greg Mann


On March 16, 2018, 7:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65300/
> ---
> 
> (Updated March 16, 2018, 7:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added master metrics for operation status acknowledgments handling.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 0fba5cede553e2030260dcf8401d48e66e740270 
>   src/master/metrics.hpp b343904bd99defffe098077855d686b2d33c1fc1 
>   src/master/metrics.cpp b627372fd09b84aeda0b8e1b209d3bc0547faa39 
> 
> 
> Diff: https://reviews.apache.org/r/65300/diff/6/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-03-19 Thread Gaston Kleiman 


> On March 19, 2018, 9:41 a.m., Zhitao Li wrote:
> > src/master/metrics.cpp
> > Line 484 (original), 498 (patched)
> > 
> >
> > I'm not sure how this pattern can sustain in the long run as long as we 
> > keep adding new scheduler calls.
> > 
> > For the long term, do you think we should have a pattern to 
> > automatically register a counter for every possible value of an enum (which 
> > should be obtainable from protobuf generated code of the type)?
> > 
> > This is more of a long term ask.

Yeah, I chatted aboutt his with Greg a while ago, and we think that in the 
future (when MESOS-8533 is resolved) the implementation of this method should 
be similar to `Metrics::incrementTasksStates()`.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/#review199424
---


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65300/
> ---
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added master metrics for operation status acknowledgments handling.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 0fba5cede553e2030260dcf8401d48e66e740270 
>   src/master/metrics.hpp b343904bd99defffe098077855d686b2d33c1fc1 
>   src/master/metrics.cpp b627372fd09b84aeda0b8e1b209d3bc0547faa39 
> 
> 
> Diff: https://reviews.apache.org/r/65300/diff/6/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-03-19 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/#review199424
---


Ship it!




Ship It!


src/master/metrics.cpp
Line 484 (original), 498 (patched)


I'm not sure how this pattern can sustain in the long run as long as we 
keep adding new scheduler calls.

For the long term, do you think we should have a pattern to automatically 
register a counter for every possible value of an enum (which should be 
obtainable from protobuf generated code of the type)?

This is more of a long term ask.


- Zhitao Li


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65300/
> ---
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added master metrics for operation status acknowledgments handling.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 0fba5cede553e2030260dcf8401d48e66e740270 
>   src/master/metrics.hpp b343904bd99defffe098077855d686b2d33c1fc1 
>   src/master/metrics.cpp b627372fd09b84aeda0b8e1b209d3bc0547faa39 
> 
> 
> Diff: https://reviews.apache.org/r/65300/diff/6/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-03-14 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/
---

(Updated March 14, 2018, 2 a.m.)


Review request for mesos and Greg Mann.


Changes
---

Rebased on top of https://reviews.apache.org/r/63994/.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added master metrics for operation status acknowledgments handling.


Diffs (updated)
-

  docs/monitoring.md 0fba5cede553e2030260dcf8401d48e66e740270 
  src/master/metrics.hpp b343904bd99defffe098077855d686b2d33c1fc1 
  src/master/metrics.cpp b627372fd09b84aeda0b8e1b209d3bc0547faa39 


Diff: https://reviews.apache.org/r/65300/diff/6/

Changes: https://reviews.apache.org/r/65300/diff/5-6/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-02-01 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/
---

(Updated Feb. 1, 2018, 3:49 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Rebase.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added master metrics for operation status acknowledgments handling.


Diffs (updated)
-

  docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b 
  src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491 
  src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba 


Diff: https://reviews.apache.org/r/65300/diff/4/

Changes: https://reviews.apache.org/r/65300/diff/3-4/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-01-26 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/
---

(Updated Jan. 26, 2018, 2:08 p.m.)


Review request for mesos and Greg Mann.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added master metrics for operation status acknowledgments handling.


Diffs (updated)
-

  docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b 
  src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491 
  src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba 


Diff: https://reviews.apache.org/r/65300/diff/3/

Changes: https://reviews.apache.org/r/65300/diff/2-3/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-01-26 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/
---

(Updated Jan. 26, 2018, 1:45 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Addressed feedback.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added master metrics for operation status acknowledgments handling.


Diffs (updated)
-

  docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b 
  src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491 
  src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba 


Diff: https://reviews.apache.org/r/65300/diff/2/

Changes: https://reviews.apache.org/r/65300/diff/1-2/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-01-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/#review196291
---




docs/monitoring.md
Lines 710-716 (patched)


Looks like these are in alphabetical order - could you move this up?


- Greg Mann


On Jan. 23, 2018, 10:17 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65300/
> ---
> 
> (Updated Jan. 23, 2018, 10:17 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added master metrics for operation status acknowledgments handling.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b 
>   src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491 
>   src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba 
> 
> 
> Diff: https://reviews.apache.org/r/65300/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-01-23 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65300/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Added master metrics for operation status acknowledgments handling.


Diffs
-

  docs/monitoring.md 7ad15b4f821108083b5f9f4381c33d5f465d361b 
  src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491 
  src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba 


Diff: https://reviews.apache.org/r/65300/diff/1/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman