Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-04-12 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/
---

(Updated April 12, 2018, 12:39 p.m.)


Review request for mesos, Benjamin Bannier and Kevin Klues.


Changes
---

Removed change regarding deactivation of existing virtualenv.


Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240


Repository: mesos


Description
---

If the absolute path to the Python interpreter is long, it may exceed
the maximum length allowed for a shebang line (limit set to 128 on many
Linux distributions). When the shebang length limit is exceeded, pip
fails with the error: "bad interpreter: No such file or directory".

A work-around for this problem is to run the pip library module which is
what we do in this patch. This will also be done to use PyInstaller.


Diffs (updated)
-

  src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 


Diff: https://reviews.apache.org/r/65705/diff/5/

Changes: https://reviews.apache.org/r/65705/diff/4-5/


Testing
---

Tested on internal CI.


Thanks,

Armand Grillet

Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-04-12 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/#review200996
---


Ship it!




Ship It!

- Kevin Klues


On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65705/
> ---
> 
> (Updated March 24, 2018, 11:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the absolute path to the Python interpreter is long, it may exceed
> the maximum length allowed for a shebang line (limit set to 128 on many
> Linux distributions). When the shebang length limit is exceeded, pip
> fails with the error: "bad interpreter: No such file or directory".
> 
> A work-around for this problem is to run the pip library module which is
> what we do in this patch. This will also be done to use PyInstaller.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 
> 
> 
> Diff: https://reviews.apache.org/r/65705/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on internal CI.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-04-12 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/#review200994
---




src/python/cli_new/bootstrap
Line 27 (original), 27 (patched)


I see why this is a good change, but in the future, this should be done in 
a seperate commit.


- Kevin Klues


On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65705/
> ---
> 
> (Updated March 24, 2018, 11:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the absolute path to the Python interpreter is long, it may exceed
> the maximum length allowed for a shebang line (limit set to 128 on many
> Linux distributions). When the shebang length limit is exceeded, pip
> fails with the error: "bad interpreter: No such file or directory".
> 
> A work-around for this problem is to run the pip library module which is
> what we do in this patch. This will also be done to use PyInstaller.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 
> 
> 
> Diff: https://reviews.apache.org/r/65705/diff/4/
> 
> 
> Testing
> ---
> 
> Tested on internal CI.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-03-24 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/
---

(Updated March 24, 2018, 11:39 a.m.)


Review request for mesos, Benjamin Bannier and Kevin Klues.


Changes
---

Rebased.


Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240


Repository: mesos


Description
---

If the absolute path to the Python interpreter is long, it may exceed
the maximum length allowed for a shebang line (limit set to 128 on many
Linux distributions). When the shebang length limit is exceeded, pip
fails with the error: "bad interpreter: No such file or directory".

A work-around for this problem is to run the pip library module which is
what we do in this patch. This will also be done to use PyInstaller.


Diffs (updated)
-

  src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 


Diff: https://reviews.apache.org/r/65705/diff/3/

Changes: https://reviews.apache.org/r/65705/diff/2-3/


Testing
---

Tested on internal CI.


Thanks,

Armand Grillet

Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-02-19 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/#review197752
---


Ship it!





src/python/cli_new/bootstrap
Line 27 (original), 27 (patched)


Maybe not an issue for this patch, but couldn't we just `deactivate` from 
the script here instead of stopping? We already know that virtualenvs cannot be 
nested.


- Benjamin Bannier


On Feb. 18, 2018, 4:14 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65705/
> ---
> 
> (Updated Feb. 18, 2018, 4:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the absolute path to the Python interpreter is long, it may exceed
> the maximum length allowed for a shebang line (limit set to 128 on many
> Linux distributions). When the shebang length limit is exceeded, pip
> fails with the error: "bad interpreter: No such file or directory".
> 
> A work-around for this problem is to run the pip library module which is
> what we do in this patch. This will also be done to use PyInstaller.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 
> 
> 
> Diff: https://reviews.apache.org/r/65705/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on internal CI.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-02-18 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/
---

Review request for mesos, Benjamin Bannier and Kevin Klues.


Repository: mesos


Description
---

If the absolute path to the Python interpreter is long, it may exceed
the maximum length allowed for a shebang line (limit set to 128 on many
Linux distributions). When the shebang length limit is exceeded, pip
fails with the error: "bad interpreter: No such file or directory".

A work-around for this problem is to run the pip library module which is
what we do in this patch. This will also be done to use PyInstaller.


Diffs
-

  src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 


Diff: https://reviews.apache.org/r/65705/diff/1/


Testing
---

Tested on internal CI.


Thanks,

Armand Grillet