Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

2018-03-22 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66058/
---

(Updated March 22, 2018, 11:27 a.m.)


Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li.


Changes
---

Rebased.


Bugs: MESOS-8201
https://issues.apache.org/jira/browse/MESOS-8201


Repository: mesos


Description
---

Added v1 versions of some test helpers/matchers.


Diffs (updated)
-

  src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 


Diff: https://reviews.apache.org/r/66058/diff/3/

Changes: https://reviews.apache.org/r/66058/diff/2-3/


Testing
---

Used by the tests added in https://reviews.apache.org/r/66060/.


Thanks,

Gaston Kleiman

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

2018-03-19 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66058/
---

(Updated March 19, 2018, 6:54 p.m.)


Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li.


Changes
---

Addressed Greg's comment.


Bugs: MESOS-8201
https://issues.apache.org/jira/browse/MESOS-8201


Repository: mesos


Description
---

Added v1 versions of some test helpers/matchers.


Diffs (updated)
-

  src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 


Diff: https://reviews.apache.org/r/66058/diff/2/

Changes: https://reviews.apache.org/r/66058/diff/1-2/


Testing
---

Used by the tests added in https://reviews.apache.org/r/66060/.


Thanks,

Gaston Kleiman

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

2018-03-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66058/#review199492
---


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 2581 (patched)


Could you use `foreach` here?


- Greg Mann


On March 16, 2018, 7:58 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66058/
> ---
> 
> (Updated March 16, 2018, 7:58 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-8201
> https://issues.apache.org/jira/browse/MESOS-8201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added v1 versions of some test helpers/matchers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 
> 
> 
> Diff: https://reviews.apache.org/r/66058/diff/1/
> 
> 
> Testing
> ---
> 
> Used by the tests added in https://reviews.apache.org/r/66060/.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

2018-03-19 Thread Gaston Kleiman 


> On March 19, 2018, 10:14 a.m., Zhitao Li wrote:
> > src/tests/mesos.hpp
> > Lines 2574 (patched)
> > 
> >
> > Do we need to make this `ACTION_P` and takes a (decline) `Filters`?

I think we should add helpers as we need them. We have (and use) both versions 
for the v0 API, so it would make sense to add a version that takes a `Filters` 
as soon as a test would need it.

I wouldn't add it now, I am not a fan of adding helpers that aren't [yet] used.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66058/#review199430
---


On March 16, 2018, 12:58 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66058/
> ---
> 
> (Updated March 16, 2018, 12:58 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-8201
> https://issues.apache.org/jira/browse/MESOS-8201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added v1 versions of some test helpers/matchers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 
> 
> 
> Diff: https://reviews.apache.org/r/66058/diff/1/
> 
> 
> Testing
> ---
> 
> Used by the tests added in https://reviews.apache.org/r/66060/.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

2018-03-19 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66058/#review199430
---




src/tests/mesos.hpp
Lines 2574 (patched)


Do we need to make this `ACTION_P` and takes a (decline) `Filters`?


- Zhitao Li


On March 16, 2018, 12:58 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66058/
> ---
> 
> (Updated March 16, 2018, 12:58 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-8201
> https://issues.apache.org/jira/browse/MESOS-8201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added v1 versions of some test helpers/matchers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 
> 
> 
> Diff: https://reviews.apache.org/r/66058/diff/1/
> 
> 
> Testing
> ---
> 
> Used by the tests added in https://reviews.apache.org/r/66060/.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 66058: Added v1 versions of some test helpers/matchers.

2018-03-14 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66058/
---

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-8201
https://issues.apache.org/jira/browse/MESOS-8201


Repository: mesos


Description
---

Added v1 versions of some test helpers/matchers.


Diffs
-

  src/tests/mesos.hpp 2c3d0c9350cd2223ff20c0797d1849d38c19 


Diff: https://reviews.apache.org/r/66058/diff/1/


Testing
---

Used by the tests added in https://reviews.apache.org/r/66060/.


Thanks,

Gaston Kleiman