Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-05-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated May 9, 2018, 9:15 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review202529 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp Lines 688

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-05-02 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated May 3, 2018, 12:05 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-05-02 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review202330 --- As discussed in our direct review, some more changes on the

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-12 Thread Kapil Arya
> On April 12, 2018, 8:19 p.m., Till Toenshoff wrote: > > src/master/validation.cpp > > Lines 532 (patched) > > > > > > s/is/are/ > > > > How do we make sure the role is "valid" - isn't that implicit when

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 12, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review201053 --- Looks great Kapil - just some minor comments on logging and

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 11, 2018, 1:28 p.m.) Review request for mesos, Benjamin Mahler

Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-03-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258