Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200458 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 2:34 p.m.) Review request for mesos, Andrew

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200447 --- Patch looks great! Reviews applied: [66314] Passed command:

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200441 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 6:45 a.m.) Review request for mesos, Andrew

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On März 28, 2018, 10:06 vorm., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200431 --- PASS: Mesos patch 66314 was successfully built and tested.

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 3:33 a.m.) Review request for mesos, Andrew

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On April 2, 2018, 11:42 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 359-360 (original), 365-366 (patched) > > > > > > If I understood the above discussion correctly, I think the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On April 2, 2018, 8:42 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 359-360 (original), 365-366 (patched) > > > > > > If I understood the above discussion correctly, I think the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 10:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On April 2, 2018, 6:42 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 359-360 (original), 365-366 (patched) > > > > > > If I understood the above discussion correctly, I think the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200305 --- 3rdparty/CMakeLists.txt Lines 359-360 (original), 365-366

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- 3rdparty/CMakeLists.txt Lines 58-63 (patched)

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200078 --- Patch looks great! Reviews applied: [66314] Passed command:

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200073 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- Review request for mesos. Bugs: MESOS-4176