Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202239
---


Ship it!




Ship It!

- Joseph Wu


On May 1, 2018, 3:43 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66834/
> ---
> 
> (Updated May 1, 2018, 3:43 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Specialized `flags::parse`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 
> 
> 
> Diff: https://reviews.apache.org/r/66834/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/
---

(Updated May 1, 2018, 3:43 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Changes
---

Return error if string doesn't split into exactly two parts.


Repository: mesos


Description
---

Windows: Specialized `flags::parse`.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/parse.hpp 
eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 


Diff: https://reviews.apache.org/r/66834/diff/2/

Changes: https://reviews.apache.org/r/66834/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Andrew Schwartzmeyer 


> On May 1, 2018, 2:48 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/flags/parse.hpp
> > Lines 197-200 (patched)
> > 
> >
> > There should be a check for exactly 2 tokens here.  Instead of using 
> > the `maxTokens` parameter of `strings::split`.
> > 
> > The existing code would crash pretty easily.

> The existing code would crash pretty easily.

The `operator>>` on `WindowsFD` would have to be manually changed to cause a 
crash here, but I hear you. I'll split and `CHECK`.


> On May 1, 2018, 2:48 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/flags/parse.hpp
> > Lines 201 (patched)
> > 
> >
> > I must be missing something... Where are `parse` and 
> > `parse` defined?

It's the generic template above; uses an `istringstream` which handles `void*` 
and `unisgned __int64` in the STL.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202226
---


On April 26, 2018, 9:22 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66834/
> ---
> 
> (Updated April 26, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Specialized `flags::parse`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 
> 
> 
> Diff: https://reviews.apache.org/r/66834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202226
---




3rdparty/stout/include/stout/flags/parse.hpp
Lines 197-200 (patched)


There should be a check for exactly 2 tokens here.  Instead of using the 
`maxTokens` parameter of `strings::split`.

The existing code would crash pretty easily.



3rdparty/stout/include/stout/flags/parse.hpp
Lines 201 (patched)


I must be missing something... Where are `parse` and 
`parse` defined?


- Joseph Wu


On April 26, 2018, 9:22 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66834/
> ---
> 
> (Updated April 26, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Specialized `flags::parse`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 
> 
> 
> Diff: https://reviews.apache.org/r/66834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-04-30 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202135
---


Ship it!




Ship It!

- Akash Gupta


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66834/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Specialized `flags::parse`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 
> 
> 
> Diff: https://reviews.apache.org/r/66834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-04-27 Thread John Kordich via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202086
---


Ship it!




Ship It!

- John Kordich


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66834/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Specialized `flags::parse`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 
> 
> 
> Diff: https://reviews.apache.org/r/66834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 66834: Windows: Specialized `flags::parse`.

2018-04-26 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Repository: mesos


Description
---

Windows: Specialized `flags::parse`.


Diffs
-

  3rdparty/stout/include/stout/flags/parse.hpp 
eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 


Diff: https://reviews.apache.org/r/66834/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer