Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

2018-05-25 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67145/#review203898
---


Ship it!




Ship It!

- Jie Yu


On May 24, 2018, 12:28 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67145/
> ---
> 
> (Updated May 24, 2018, 12:28 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test to verify that the `linux/devices` isolator supports
> populating devices that are whitelisted by the `allowed_devices`
> agent flag.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
>   src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67145/diff/7/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

2018-05-23 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67145/
---

(Updated May 24, 2018, 12:28 a.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8792
https://issues.apache.org/jira/browse/MESOS-8792


Repository: mesos


Description
---

Added test to verify that the `linux/devices` isolator supports
populating devices that are whitelisted by the `allowed_devices`
agent flag.


Diffs (updated)
-

  src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
  src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc 
  src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67145/diff/6/

Changes: https://reviews.apache.org/r/67145/diff/5-6/


Testing
---

make check (Fedora 27)


Thanks,

James Peach

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

2018-05-23 Thread James Peach 


> On May 23, 2018, 7:05 p.m., Jie Yu wrote:
> > src/tests/containerizer/linux_devices_isolator_tests.cpp
> > Lines 133 (patched)
> > 
> >
> > ```[jie@core-dev ~]$ echo $SUDO_USER
> > 
> > ```
> > 
> > It does not exist on my linux box.
> > 
> > ```[jie@core-dev ~]$ cat /etc/redhat-release 
> > CentOS Linux release 7.4.1708 (Core) ```

Discussed on slack. `sudo` will set `$SUDO_USER` when you run the tests as root 
by doing `sudo ./src/mesos-tests ...`. In this case, we need a non-root user 
that is on the system, and `$SUDO_USER` is the name of the user account that 
originally started the tests. I'm assuming that everyone will use `sudo` to run 
the tests as `root` rather than actually logging into a console as `root`.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67145/#review203678
---


On May 16, 2018, 12:30 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67145/
> ---
> 
> (Updated May 16, 2018, 12:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test to verify that the `linux/devices` isolator supports
> populating devices that are whitelisted by the `allowed_devices`
> agent flag.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
>   src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67145/diff/5/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

2018-05-23 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67145/#review203678
---




src/tests/containerizer/linux_devices_isolator_tests.cpp
Lines 133 (patched)


```[jie@core-dev ~]$ echo $SUDO_USER

```

It does not exist on my linux box.

```[jie@core-dev ~]$ cat /etc/redhat-release 
CentOS Linux release 7.4.1708 (Core) ```


- Jie Yu


On May 16, 2018, 12:30 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67145/
> ---
> 
> (Updated May 16, 2018, 12:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test to verify that the `linux/devices` isolator supports
> populating devices that are whitelisted by the `allowed_devices`
> agent flag.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
>   src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67145/diff/5/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

2018-05-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67145/#review203195
---



PASS: Mesos patch 67145 was successfully built and tested.

Reviews applied: `['67094', '67095', '67096', '67097', '67098', '67145']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67145

- Mesos Reviewbot Windows


On May 16, 2018, 12:30 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67145/
> ---
> 
> (Updated May 16, 2018, 12:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test to verify that the `linux/devices` isolator supports
> populating devices that are whitelisted by the `allowed_devices`
> agent flag.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
>   src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67145/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27)
> 
> The following tests fail with this review chain:
> 
> [  FAILED  ] 19 tests, listed below:
> [  FAILED  ] 
> HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPSWithContainerImage
> [  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_Usage
> [  FAILED  ] VolumeSandboxPathIsolatorTest.ROOT_SelfType
> [  FAILED  ] VolumeSandboxPathIsolatorTest.ROOT_SelfTypeOwnership
> [  FAILED  ] VolumeHostPathIsolatorTest.ROOT_VolumeFromHost
> [  FAILED  ] VolumeHostPathIsolatorTest.ROOT_FileVolumeFromHost
> [  FAILED  ] PortMappingIsolatorTest.ROOT_NC_ContainerToContainerTCP
> [  FAILED  ] PortMappingIsolatorTest.ROOT_NC_ContainerToContainerUDP
> [  FAILED  ] PortMappingIsolatorTest.ROOT_NC_HostToContainerUDP
> [  FAILED  ] PortMappingIsolatorTest.ROOT_NC_HostToContainerTCP
> [  FAILED  ] PortMappingIsolatorTest.ROOT_ContainerARPExternal
> [  FAILED  ] PortMappingIsolatorTest.ROOT_NC_SmallEgressLimit
> [  FAILED  ] PortMappingMesosTest.CGROUPS_ROOT_RecoverMixedContainers
> [  FAILED  ] 
> PortMappingMesosTest.CGROUPS_ROOT_RecoverMixedKnownAndUnKnownOrphans
> [  FAILED  ] 
> bool/UserContainerLoggerTest.ROOT_LOGROTATE_RotateWithSwitchUserTrueOrFalse/0,
>  where GetParam() = true
> [  FAILED  ] 
> ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2, where 
> GetParam() = "quay.io/coreos/alpine-sh"
> [  FAILED  ] 
> JoinParentsNetworkParam/NestedContainerCniTest.ROOT_INTERNET_CURL_VerifyContainerHostname/0,
>  where GetParam() = true
> [  FAILED  ] 
> JoinParentsNetworkParam/NestedContainerCniTest.ROOT_INTERNET_CURL_VerifyContainerHostname/1,
>  where GetParam() = false
> [  FAILED  ] 
> ExecutorType/VolumeHostPathIsolatorMesosTest.ROOT_ChangeRootFilesystem/DefaultExecutor,
>  where GetParam() = 4-byte object <01-00 00-00>
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 67145: Added `linux/devices` isolator whitelist tests.

2018-05-15 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67145/
---

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8792
https://issues.apache.org/jira/browse/MESOS-8792


Repository: mesos


Description
---

Added test to verify that the `linux/devices` isolator supports
populating devices that are whitelisted by the `allowed_devices`
agent flag.


Diffs
-

  src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
  src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc 
  src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67145/diff/1/


Testing
---

make check (Fedora 27)

The following tests fail with this review chain:

[  FAILED  ] 19 tests, listed below:
[  FAILED  ] 
HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPSWithContainerImage
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_Usage
[  FAILED  ] VolumeSandboxPathIsolatorTest.ROOT_SelfType
[  FAILED  ] VolumeSandboxPathIsolatorTest.ROOT_SelfTypeOwnership
[  FAILED  ] VolumeHostPathIsolatorTest.ROOT_VolumeFromHost
[  FAILED  ] VolumeHostPathIsolatorTest.ROOT_FileVolumeFromHost
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_ContainerToContainerTCP
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_ContainerToContainerUDP
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_HostToContainerUDP
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_HostToContainerTCP
[  FAILED  ] PortMappingIsolatorTest.ROOT_ContainerARPExternal
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_SmallEgressLimit
[  FAILED  ] PortMappingMesosTest.CGROUPS_ROOT_RecoverMixedContainers
[  FAILED  ] 
PortMappingMesosTest.CGROUPS_ROOT_RecoverMixedKnownAndUnKnownOrphans
[  FAILED  ] 
bool/UserContainerLoggerTest.ROOT_LOGROTATE_RotateWithSwitchUserTrueOrFalse/0, 
where GetParam() = true
[  FAILED  ] 
ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2, where 
GetParam() = "quay.io/coreos/alpine-sh"
[  FAILED  ] 
JoinParentsNetworkParam/NestedContainerCniTest.ROOT_INTERNET_CURL_VerifyContainerHostname/0,
 where GetParam() = true
[  FAILED  ] 
JoinParentsNetworkParam/NestedContainerCniTest.ROOT_INTERNET_CURL_VerifyContainerHostname/1,
 where GetParam() = false
[  FAILED  ] 
ExecutorType/VolumeHostPathIsolatorMesosTest.ROOT_ChangeRootFilesystem/DefaultExecutor,
 where GetParam() = 4-byte object <01-00 00-00>


Thanks,

James Peach