Re: Review Request 67910: Fixed virtualenv management in support directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/#review206072 --- Ship it! I've split this into 3 commits on my end and slightly changed some variable names in the commit that actually fixes the virtualenv management. Please see the commit logs for details. - Kevin Klues On July 13, 2018, 4:38 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67910/ > --- > > (Updated July 13, 2018, 4:38 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9075 > https://issues.apache.org/jira/browse/MESOS-9075 > > > Repository: mesos > > > Description > --- > > The switch from Python 2 to Python 3 creates problems regarding the > virtual environment if a developer dangles between Python 2 and 3 as > we want the virtual environment to use the same version of Python as > the user to give useful logs when linting. > > This commit fixes the issue by adding a new check in the function of > `mesos-style.py` called `should_build_virtualenv` to see if the Python > interpreter version currently used is the one in the virtual > environement. If not, the virtual environment will get recreated. > > > Diffs > - > > support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 > support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 > > > Diff: https://reviews.apache.org/r/67910/diff/2/ > > > Testing > --- > > Run the two `mesos-style.py` and `build-virtualenv` with > `MESOS_SUPPORT_PYTHON` set to 3 or not. Checked that the python intepreter > installed in the virtual environment was correct. > > > Thanks, > > Armand Grillet > >
Re: Review Request 67910: Fixed virtualenv management in support directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/#review206061 --- PASS: Mesos patch 67910 was successfully built and tested. Reviews applied: `['67910']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1919/mesos-review-67910 - Mesos Reviewbot Windows On July 13, 2018, 4:38 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67910/ > --- > > (Updated July 13, 2018, 4:38 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9075 > https://issues.apache.org/jira/browse/MESOS-9075 > > > Repository: mesos > > > Description > --- > > The switch from Python 2 to Python 3 creates problems regarding the > virtual environment if a developer dangles between Python 2 and 3 as > we want the virtual environment to use the same version of Python as > the user to give useful logs when linting. > > This commit fixes the issue by adding a new check in the function of > `mesos-style.py` called `should_build_virtualenv` to see if the Python > interpreter version currently used is the one in the virtual > environement. If not, the virtual environment will get recreated. > > > Diffs > - > > support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 > support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 > > > Diff: https://reviews.apache.org/r/67910/diff/2/ > > > Testing > --- > > Run the two `mesos-style.py` and `build-virtualenv` with > `MESOS_SUPPORT_PYTHON` set to 3 or not. Checked that the python intepreter > installed in the virtual environment was correct. > > > Thanks, > > Armand Grillet > >
Re: Review Request 67910: Fixed virtualenv management in support directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/ --- (Updated July 13, 2018, 4:38 p.m.) Review request for mesos and Kevin Klues. Changes --- Rebased. Bugs: MESOS-9075 https://issues.apache.org/jira/browse/MESOS-9075 Repository: mesos Description (updated) --- The switch from Python 2 to Python 3 creates problems regarding the virtual environment if a developer dangles between Python 2 and 3 as we want the virtual environment to use the same version of Python as the user to give useful logs when linting. This commit fixes the issue by adding a new check in the function of `mesos-style.py` called `should_build_virtualenv` to see if the Python interpreter version currently used is the one in the virtual environement. If not, the virtual environment will get recreated. Diffs (updated) - support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 Diff: https://reviews.apache.org/r/67910/diff/2/ Changes: https://reviews.apache.org/r/67910/diff/1-2/ Testing --- Run the two `mesos-style.py` and `build-virtualenv` with `MESOS_SUPPORT_PYTHON` set to 3 or not. Checked that the python intepreter installed in the virtual environment was correct. Thanks, Armand Grillet
Review Request 67910: Fixed virtualenv management in support directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67910/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9075 https://issues.apache.org/jira/browse/MESOS-9075 Repository: mesos Description --- The switch from Python 2 to Python 3 creates problems regarding the virtual environment if a developer dangles between Python 2 and 3 as we want the virtual environment to use the same version of Python as the user to give useful logs when linting. This commit fixes the issue by adding a new check in the function of `mesos-style.py` called `should_build_virtualenv` to see if the Python interpreter version currently used is the one in the virtual environement. If not, the virtual environment will get recreated. A second issue was that running `build-virtualenv` with Python 3 then again with Python 2 would end up with two versions of Python in the virtualenv and continue to use Python 3 in that environment. This is due to an old issue of `virtualenv` that we now handle by removing the entire virtual environment before building it again. Diffs - support/build-virtualenv b8dc1d98f97bc70d9f7099db2c9cb85a884be12c support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 Diff: https://reviews.apache.org/r/67910/diff/1/ Testing --- Run the two `mesos-style.py` and `build-virtualenv` with `MESOS_SUPPORT_PYTHON` set to 3 or not. Checked that the python intepreter installed in the virtual environment was correct. Thanks, Armand Grillet
