Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-28 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review208062
---


Ship it!




Ship It!

- Jie Yu


On Aug. 17, 2018, 3:37 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 17, 2018, 3:37 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 63b109bdbc23733aa3d4cdce1de5385ad9933be8 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/6/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-17 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207503
---



Patch looks great!

Reviews applied: [68052, 68053, 68054, 68355]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 17, 2018, 3:37 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 17, 2018, 3:37 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 63b109bdbc23733aa3d4cdce1de5385ad9933be8 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/6/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207477
---



PASS: Mesos patch 68355 was successfully built and tested.

Reviews applied: `['68052', '68355']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2182/mesos-review-68355

- Mesos Reviewbot Windows


On Aug. 16, 2018, 8:37 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 16, 2018, 8:37 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 63b109bdbc23733aa3d4cdce1de5385ad9933be8 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/6/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-16 Thread Sergey Urbanovich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/
---

(Updated Aug. 17, 2018, 3:37 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Minor change.


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

This is a veth CNI plugin that is written in bash. It creates a veth
virtual network pair, one end of the pair will be moved to container
network namespace.

The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
documentation and examples [rfc5737]. The plugin can allocate up to
128 veth pairs.


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp 
63b109bdbc23733aa3d4cdce1de5385ad9933be8 
  src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 


Diff: https://reviews.apache.org/r/68355/diff/6/

Changes: https://reviews.apache.org/r/68355/diff/5-6/


Testing
---

bin/mesos-tests.sh --verbose 
--gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
--gtest_break_on_failure --gtest_repeat=100


Thanks,

Sergey Urbanovich

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-16 Thread Sergey Urbanovich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/
---

(Updated Aug. 17, 2018, 3:30 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Fixed the test filter for veth CNI plugin.


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

This is a veth CNI plugin that is written in bash. It creates a veth
virtual network pair, one end of the pair will be moved to container
network namespace.

The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
documentation and examples [rfc5737]. The plugin can allocate up to
128 veth pairs.


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp 
63b109bdbc23733aa3d4cdce1de5385ad9933be8 
  src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 


Diff: https://reviews.apache.org/r/68355/diff/5/

Changes: https://reviews.apache.org/r/68355/diff/4-5/


Testing
---

bin/mesos-tests.sh --verbose 
--gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
--gtest_break_on_failure --gtest_repeat=100


Thanks,

Sergey Urbanovich

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207459
---



PASS: Mesos patch 68355 was successfully built and tested.

Reviews applied: `['68052', '68355']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2176/mesos-review-68355

- Mesos Reviewbot Windows


On Aug. 16, 2018, 9:55 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 16, 2018, 9:55 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 63b109bdbc23733aa3d4cdce1de5385ad9933be8 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/4/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207458
---



Patch looks great!

Reviews applied: [68052, 68053, 68054, 68355]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 16, 2018, 7:55 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 16, 2018, 7:55 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 63b109bdbc23733aa3d4cdce1de5385ad9933be8 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/4/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-16 Thread Sergey Urbanovich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/
---

(Updated Aug. 16, 2018, 7:55 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Add a test filter for veth CNI plugin.


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

This is a veth CNI plugin that is written in bash. It creates a veth
virtual network pair, one end of the pair will be moved to container
network namespace.

The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
documentation and examples [rfc5737]. The plugin can allocate up to
128 veth pairs.


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp 
63b109bdbc23733aa3d4cdce1de5385ad9933be8 
  src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 


Diff: https://reviews.apache.org/r/68355/diff/4/

Changes: https://reviews.apache.org/r/68355/diff/3-4/


Testing
---

bin/mesos-tests.sh --verbose 
--gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
--gtest_break_on_failure --gtest_repeat=100


Thanks,

Sergey Urbanovich

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207393
---



Patch looks great!

Reviews applied: [68052, 68053, 68054, 68355]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 15, 2018, 7:06 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 15, 2018, 7:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb22e73b4215b5b0a49ac610e5f657b73d38963b 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/3/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207361
---



FAIL: Failed to apply the dependent review: 68054.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68054`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2163/mesos-review-68355

- Mesos Reviewbot Windows


On Aug. 15, 2018, 12:06 p.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 15, 2018, 12:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb22e73b4215b5b0a49ac610e5f657b73d38963b 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/3/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Sergey Urbanovich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/
---

(Updated Aug. 15, 2018, 7:06 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Yet another fix.


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

This is a veth CNI plugin that is written in bash. It creates a veth
virtual network pair, one end of the pair will be moved to container
network namespace.

The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
documentation and examples [rfc5737]. The plugin can allocate up to
128 veth pairs.


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp 
cb22e73b4215b5b0a49ac610e5f657b73d38963b 


Diff: https://reviews.apache.org/r/68355/diff/3/

Changes: https://reviews.apache.org/r/68355/diff/2-3/


Testing
---

bin/mesos-tests.sh --verbose 
--gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
--gtest_break_on_failure --gtest_repeat=100


Thanks,

Sergey Urbanovich

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207338
---




src/tests/containerizer/cni_isolator_tests.cpp
Lines 220 (patched)


Errors must be indicated by a non-zero return code


- Jie Yu


On Aug. 15, 2018, 6:02 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 15, 2018, 6:02 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb22e73b4215b5b0a49ac610e5f657b73d38963b 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/2/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207320
---



Patch looks great!

Reviews applied: [68052, 68053, 68054, 68355]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 15, 2018, 6:02 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 15, 2018, 6:02 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb22e73b4215b5b0a49ac610e5f657b73d38963b 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/2/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207317
---



PASS: Mesos patch 68355 was successfully built and tested.

Reviews applied: `['68052', '68054', '68355']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2157/mesos-review-68355

- Mesos Reviewbot Windows


On Aug. 15, 2018, 8:02 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 15, 2018, 8:02 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb22e73b4215b5b0a49ac610e5f657b73d38963b 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/2/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-15 Thread Sergey Urbanovich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/
---

(Updated Aug. 15, 2018, 6:02 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Addressed the comments.


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

This is a veth CNI plugin that is written in bash. It creates a veth
virtual network pair, one end of the pair will be moved to container
network namespace.

The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
documentation and examples [rfc5737]. The plugin can allocate up to
128 veth pairs.


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp 
cb22e73b4215b5b0a49ac610e5f657b73d38963b 


Diff: https://reviews.apache.org/r/68355/diff/2/

Changes: https://reviews.apache.org/r/68355/diff/1-2/


Testing
---

bin/mesos-tests.sh --verbose 
--gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
--gtest_break_on_failure --gtest_repeat=100


Thanks,

Sergey Urbanovich

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-14 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207304
---




src/tests/containerizer/cni_isolator_tests.cpp
Lines 203 (patched)


nits: I'd suggest we don't to link break here. Lint won't check c++11 
string literals.



src/tests/containerizer/cni_isolator_tests.cpp
Lines 207 (patched)


nits: Ditto. Let's use one line for those command



src/tests/containerizer/cni_isolator_tests.cpp
Lines 216-219 (patched)


Why you need this?



src/tests/containerizer/cni_isolator_tests.cpp
Lines 229 (patched)


I'd suggest we use `trap` to do the cleanup in case any command throw an 
error:
```
...
ln -sf $CNI_NETNS /var/run/netns/$NETNS

function cleanup() {
  rm -f /var/run/netns/$NETNS
}

trap cleanup EXIT
```



src/tests/containerizer/cni_isolator_tests.cpp
Lines 231-234 (patched)


I think CNI plugin's error message should be in stdout according to spec (a 
json)



src/tests/containerizer/cni_isolator_tests.cpp
Lines 236-240 (patched)


CNI DEL shouldn't output this?



src/tests/containerizer/cni_isolator_tests.cpp
Lines 2418-2421 (patched)


No need for this.



src/tests/containerizer/cni_isolator_tests.cpp
Lines 2428 (patched)


No need for this.


- Jie Yu


On Aug. 15, 2018, 1:47 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 15, 2018, 1:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb22e73b4215b5b0a49ac610e5f657b73d38963b 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/1/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

Review Request 68355: Added a CNI test for networking statistics.

2018-08-14 Thread Sergey Urbanovich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-5647
https://issues.apache.org/jira/browse/MESOS-5647


Repository: mesos


Description
---

This is a veth CNI plugin that is written in bash. It creates a veth
virtual network pair, one end of the pair will be moved to container
network namespace.

The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
documentation and examples [rfc5737]. The plugin can allocate up to
128 veth pairs.


Diffs
-

  src/tests/containerizer/cni_isolator_tests.cpp 
cb22e73b4215b5b0a49ac610e5f657b73d38963b 


Diff: https://reviews.apache.org/r/68355/diff/1/


Testing
---

bin/mesos-tests.sh --verbose 
--gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
--gtest_break_on_failure --gtest_repeat=100


Thanks,

Sergey Urbanovich