Re: Review Request 68473: Moved members of `ReadOnlyHandler` into separate file.

2018-08-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review208059 --- Fix it, then Ship it! src/master/readonly_handler.cpp Lines 19

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review207989 --- Patch looks great! Reviews applied: [68321, 68440, 68441, 68442,

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/ --- (Updated Aug. 27, 2018, 5:44 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-27 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review207985 --- PASS: Mesos patch 68473 was successfully built and tested. Review

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-27 Thread Benno Evers
> On Aug. 27, 2018, 11:18 a.m., Alexander Rukletsov wrote: > > src/common/http.hpp > > Line 165 (original), 165-174 (patched) > > > > > > I believe it was meant to be sorted alphabetically. Can you please > > restor

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-27 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/ --- (Updated Aug. 27, 2018, 2:57 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review207963 --- Nice cleanup, thank! I assume there were no functional changes, ju

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review207755 --- PASS: Mesos patch 68473 was successfully built and tested. Review

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/ --- (Updated Aug. 22, 2018, 1:32 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review207743 --- Bad review! Reviews applied: [68473] Error: No reviewers specifi

Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti