Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/#review210405 --- Ship it! Ship It! - Gilbert Song On Oct. 23, 2018, 7:30

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- (Updated Oct. 24, 2018, 10:30 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/#review209891 --- Fix it, then Ship it!

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- (Updated Oct. 20, 2018, 3:02 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/#review209786 --- Fix it, then Ship it!

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- (Updated Oct. 19, 2018, 2:57 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- (Updated Oct. 14, 2018, 9:30 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68642: Added `lsof()` into stout.

> On Sept. 6, 2018, 5:37 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/lsof.hpp > > Lines 29 (patched) > > > > > > Why hashset rather than vector? By definition there aren't any > > duplicates,

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- (Updated Oct. 11, 2018, 9:57 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68642: Added `lsof()` into stout.

> On Sept. 7, 2018, 1:37 a.m., James Peach wrote: > > We should add a basic test for this, even if it just ensures that the > > result contains the elements 0, 1 and 2. Added a test here: https://reviews.apache.org/r/68991/ > On Sept. 7, 2018, 1:37 a.m., James Peach wrote: > >

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/#review208411 --- We should add a basic test for this, even if it just ensures that

Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9152