Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211174 --- PASS: Mesos patch 69514 was successfully built and tested. Review

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/ --- (Updated Dec. 10, 2018, 2:24 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211166 --- Fix it, then Ship it! docs/monitoring.md Lines 984 (patched) <

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-10 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211141 --- Ship it! The `active_`-prefix could probably be dropped without

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211084 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/ --- (Updated Dec. 5, 2018, 6:21 p.m.) Review request for mesos, Benno Evers, Benjam

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211080 --- src/master/metrics.hpp Lines 63 (patched)

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211071 --- PASS: Mesos patch 69514 was successfully built and tested. Review

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211063 --- There is an effort to migrate all pull gauges in the master and al

Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/ --- Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Greg