Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-17 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/#review211362 --- Ship it! Ship It! - Chun-Hung Hsiao On Dec. 17, 2018, 9:57 a

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-17 Thread Benjamin Bannier
> On Dec. 14, 2018, 10:39 p.m., Chun-Hung Hsiao wrote: > > src/common/protobuf_utils.cpp > > Lines 470 (patched) > > > > > > Since we set the agent ID and RP ID here in SLRP, how about doing the > > following change

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-17 Thread Chun-Hung Hsiao
> On Dec. 14, 2018, 9:39 p.m., Chun-Hung Hsiao wrote: > > src/common/protobuf_utils.cpp > > Lines 470 (patched) > > > > > > Since we set the agent ID and RP ID here in SLRP, how about doing the > > following changes

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-17 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/ --- (Updated Dec. 17, 2018, 10:57 a.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-17 Thread Benjamin Bannier
> On Dec. 14, 2018, 10:39 p.m., Chun-Hung Hsiao wrote: > > src/common/protobuf_utils.cpp > > Lines 470 (patched) > > > > > > Since we set the agent ID and RP ID here in SLRP, how about doing the > > following change

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/#review211342 --- src/common/protobuf_utils.cpp Lines 470 (patched)

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/#review211333 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-9479 h