Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211902 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 6:52 a.m.

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 11, 2019, 3:54 p.m., Andrei Budnik wrote: > > src/slave/state.cpp > > Lines 493-500 (patched) > > > > > > All tests (including a new one) are passed after removing this code. > > Maybe we don't need to rem

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211888 --- src/slave/state.cpp Lines 493-500 (patched)

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 10, 2019, 11:41 p.m., Vinod Kone wrote: > > Can you write a unit test for this by spoofing the reboot? Here it is: https://reviews.apache.org/r/69717/ - Qian --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 11, 2019, 7:30 a.m., Gilbert Song wrote: > > Could we vertify the CI failure above `SlaveRecoveryTest/0.Reboot` is not > > caused by our change? Actually it is caused by this patch :-( And I have fixed it in this patch: https://reviews.apache.org/r/69716/ . - Qian ---

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 11, 2019, 7:29 a.m., Gilbert Song wrote: > > src/slave/state.cpp > > Line 561 (original), 592 (patched) > > > > > > Could we confirm we do not care about this marker case after reboot? After reboot, the fi

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211845 --- Could we vertify the CI failure above `SlaveRecoveryTest/0.Reboot`

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211844 --- Ship it! src/slave/state.cpp Line 561 (original), 592 (patched

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211830 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211829 --- Can you write a unit test for this by spoofing the reboot? - Vino

Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9501