Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/ --- (Updated Jan. 11, 2019, 6:09 p.m.) Review request for mesos, Deepak Goel, Gilbe

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-11 Thread Jie Yu
> On Jan. 11, 2019, 8:50 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Line 138 (original), 138 (patched) > > > > > > Should we call `ContainerizerTest::SetUp()` instead? Good catch!

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/#review211869 --- src/tests/containerizer/cni_isolator_tests.cpp Line 138 (original

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/#review211859 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 9:13 p.m.

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/ --- (Updated Jan. 11, 2019, 5:13 a.m.) Review request for mesos, Deepak Goel, Gilbe

Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/ --- Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian Zhang