Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- (Updated Feb. 12, 2019, 11:39 p.m.) Review request for mesos, Benjamin

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-12 Thread Greg Mann
> On Feb. 5, 2019, 12:28 a.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/#review212768 --- FAIL: Failed to get dependent review IDs for the current patch.

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- (Updated Feb. 12, 2019, 9:42 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-12 Thread Greg Mann
> On Feb. 5, 2019, 12:28 a.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- (Updated Feb. 12, 2019, 9:36 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-07 Thread Greg Mann
> On Feb. 5, 2019, 12:28 a.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-05 Thread Gastón Kleiman
> On Feb. 4, 2019, 4:28 p.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if it

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-02-04 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/#review212538 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 9419

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-01-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/#review212491 --- PASS: Mesos patch 69876 was successfully built and tested.

Review Request 69876: Removed operations from master state when an agent is downgraded.

2019-01-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.