Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220643 --- Patch looks great! Reviews applied: [72368, 72364] Passed

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220640 --- Ship it! Ship It! - Greg Mann On May 5, 2020, 2:05 p.m.,

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

> On May 5, 2020, 5:41 a.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 368-370 (patched) > > > > > > I don't usually need to resume the clock to get a task running update > > to go through,

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220637 --- Patch looks great! Reviews applied: [72368, 72364] Passed

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

> On May 5, 2020, 5:41 a.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 239 (patched) > > > > > > Nit: s/lead to crash/lead to a crash/ Rewrote the comment to reflect the fact that this also

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/ --- (Updated May 5, 2020, 2:05 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220627 --- Patch looks great! Reviews applied: [72368, 72364] Passed

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220617 --- src/tests/master_draining_tests.cpp Lines 239 (patched)

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220606 --- Bad patch! Reviews applied: [72368, 72364] Failed command:

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/ --- (Updated May 4, 2020, 4:12 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220592 --- Bad patch! Reviews applied: [72368, 72363, 72364] Failed

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/ --- (Updated May 4, 2020, 12:28 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220315 --- Patch looks great! Reviews applied: [72363, 72364] Passed

Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-10116