[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64413709 Just had a thought -- will `saveAsHadoopFiles` and `JobConf` need the same treatment? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64414061 That's exactlyI was seeing next. Adding an unit test at the very least. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64414369 [Test build #23842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23842/consoleFull) for PR 3457 at commit

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64415564 @srowen Yep, saveAsHadoopFiles had the same issue. Fixed it. Thanks for catching this bug! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64415622 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64415657 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64416847 [Test build #23843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23843/consoleFull) for PR 3457 at commit

[GitHub] spark pull request: [SPARK-4573] [SQL] Add SettableStructObjectIns...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3429#issuecomment-64418649 [Test build #23844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23844/consoleFull) for PR 3429 at commit

[GitHub] spark pull request: [Spark-4512] [SQL] Unresolved Attribute Except...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3386#issuecomment-64419786 [Test build #23841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23841/consoleFull) for PR 3386 at commit

[GitHub] spark pull request: [Spark-4512] [SQL] Unresolved Attribute Except...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3386#issuecomment-64419796 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SQL] add @group tab in limit() and count()

2014-11-25 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/spark/pull/3458 [SQL] add @group tab in limit() and count() @group tab is missing for scaladoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jackylk/spark

[GitHub] spark pull request: [SPARK-4451]force to kill process after 5 seco...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3316#issuecomment-64421403 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4451]force to kill process after 5 seco...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3316#issuecomment-64421394 [Test build #23840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23840/consoleFull) for PR 3316 at commit

[GitHub] spark pull request: [SQL] add @group tab in limit() and count()

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3458#issuecomment-64421787 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4573] [SQL] Add SettableStructObjectIns...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3429#issuecomment-64424934 [Test build #23844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23844/consoleFull) for PR 3429 at commit

[GitHub] spark pull request: [SPARK-4573] [SQL] Add SettableStructObjectIns...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3429#issuecomment-64424946 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4593] [SQL] return null when divider is...

2014-11-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/3443#discussion_r20874507 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -142,6 +142,8 @@ abstract class Expression extends

[GitHub] spark pull request: [SPARK-4534][Core]JavaSparkContext create new ...

2014-11-25 Thread lianhuiwang
Github user lianhuiwang closed the pull request at: https://github.com/apache/spark/pull/3403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-4593] [SQL] return null when divider is...

2014-11-25 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/3443#issuecomment-64430073 `Divide.nullable` should be `true` if it returns `null` when the divider is `0`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-4593] [SQL] return null when divider is...

2014-11-25 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/3443#issuecomment-64430796 What do you think about `IntegralType`? Currently I think it throws `ArithmeticException` when the divider is `0`. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-4534][Core]JavaSparkContext create new ...

2014-11-25 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/3403#issuecomment-64429299 OK,i will close this。thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64433265 [Test build #23843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23843/consoleFull) for PR 3457 at commit

[GitHub] spark pull request: [SPARK-4196][SPARK-4602][Streaming] Fix serial...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3457#issuecomment-64433272 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Logistic regression gradient fixed

2014-11-25 Thread daniel-acuna
Github user daniel-acuna closed the pull request at: https://github.com/apache/spark/pull/3325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-4530][MLLIB]GradientDescent get a wrong...

2014-11-25 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3399#issuecomment-64443069 This is already merged, but github is out-of-sync. Do you mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-4377] Fixed serialization issue by swit...

2014-11-25 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/3402#issuecomment-64443942 Oops, that's probably corrector, sorry! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/3459 [SPARK-4604][MLLIB] make MatrixFactorizationModel public User could construct an MF model directly. I added a note about the performance. You can merge this pull request into a Git repository by

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3459#issuecomment-64450551 [Test build #23845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23845/consoleFull) for PR 3459 at commit

[GitHub] spark pull request: [SPARK-4596][MLLib] Refactorize Normalizer to ...

2014-11-25 Thread dbtsai
Github user dbtsai closed the pull request at: https://github.com/apache/spark/pull/3446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3439#discussion_r20885397 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/SquaredError.scala --- @@ -49,18 +48,17 @@ object SquaredError extends Loss { }

[GitHub] spark pull request: [SPARK-4581][MLlib] Refactorize StandardScaler...

2014-11-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/3435#discussion_r20885451 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/StandardScaler.scala --- @@ -97,30 +97,57 @@ class StandardScalerModel private[mllib] (

[GitHub] spark pull request: [SPARK-4601][Streaming] Set correct call site ...

2014-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4535][Streaming] Fix the error in comme...

2014-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4530][MLLIB]GradientDescent get a wrong...

2014-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4381][Streaming]Add warning log when us...

2014-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4344][DOCS] adding documentation on spa...

2014-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4581][MLlib] Refactorize StandardScaler...

2014-11-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4606] Send EOF to child JVM when there'...

2014-11-25 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/3460 [SPARK-4606] Send EOF to child JVM when there's no more data to read. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-4606

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3459#issuecomment-64463562 [Test build #23845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23845/consoleFull) for PR 3459 at commit

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3459#issuecomment-64463576 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4606] Send EOF to child JVM when there'...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3460#issuecomment-64463633 [Test build #23846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23846/consoleFull) for PR 3460 at commit

[GitHub] spark pull request: [SPARK-4592] Avoid duplicate worker registrati...

2014-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3447#issuecomment-64470887 @JoshRosen I have addressed all of your high-level comments. Please have a look. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4592] Avoid duplicate worker registrati...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3447#issuecomment-64471349 [Test build #23847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23847/consoleFull) for PR 3447 at commit

[GitHub] spark pull request: [SPARK-4546] Improve HistoryServer first time ...

2014-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3411#issuecomment-64472068 @vanzin do the latest changes LGTY? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4546] Improve HistoryServer first time ...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3411#issuecomment-64472797 [Test build #23848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23848/consoleFull) for PR 3411 at commit

[GitHub] spark pull request: [SPARK-4546] Improve HistoryServer first time ...

2014-11-25 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/3411#issuecomment-64472807 Yeah, looks good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64474382 I just pushed an update which includes: * removing the 1/2 from SquaredError. This also required updating the test suite since it effectively doubles the gradient

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64474620 [Test build #23849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23849/consoleFull) for PR 3439 at commit

[GitHub] spark pull request: [SPARK-4606] Send EOF to child JVM when there'...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3460#issuecomment-64475384 [Test build #23846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23846/consoleFull) for PR 3460 at commit

[GitHub] spark pull request: [SPARK-4606] Send EOF to child JVM when there'...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3460#issuecomment-64475394 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3459#discussion_r20901054 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -28,13 +28,16 @@ import

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3459#discussion_r20901060 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -28,13 +28,16 @@ import

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3459#discussion_r20901112 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -28,13 +28,16 @@ import

[GitHub] spark pull request: [SPARK-2996] Implement userClassPathFirst for ...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3233#issuecomment-64481653 [Test build #23850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23850/consoleFull) for PR 3233 at commit

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-25 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64484066 @mateiz mind taking further review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4592] Avoid duplicate worker registrati...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3447#issuecomment-64484722 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4592] Avoid duplicate worker registrati...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3447#issuecomment-64484711 [Test build #23847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23847/consoleFull) for PR 3447 at commit

[GitHub] spark pull request: [SPARK-4546] Improve HistoryServer first time ...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3411#issuecomment-64485161 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4546] Improve HistoryServer first time ...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3411#issuecomment-64485147 [Test build #23848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23848/consoleFull) for PR 3411 at commit

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64486870 [Test build #23849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23849/consoleFull) for PR 3439 at commit

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64486875 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4592] Avoid duplicate worker registrati...

2014-11-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3447#issuecomment-64490517 LGTM; thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4592] Avoid duplicate worker registrati...

2014-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3447#issuecomment-64491924 Awesome I'm merging this thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-2996] Implement userClassPathFirst for ...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3233#issuecomment-64492313 [Test build #23850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23850/consoleFull) for PR 3233 at commit

[GitHub] spark pull request: [SPARK-2996] Implement userClassPathFirst for ...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3233#issuecomment-64492318 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4546] Improve HistoryServer first time ...

2014-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3411#issuecomment-64492458 Ok thanks I'm merging this into 1.2 and master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Fix SPARK-4471: blockManagerIdFromJson functio...

2014-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3340#issuecomment-64492616 Ok I'm merging this into 1.2 and master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...

2014-11-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3453#issuecomment-64494391 Ok, I compared the diff here with that in #2225 and verified that the content is the same. This LGTM I'm merging this into master and 1.2 thanks. --- If your project

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64497207 @jkbradley I am trying to find my reference for the LogLoss calculations. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3439#discussion_r20909144 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala --- @@ -45,19 +46,21 @@ object LogLoss extends Loss { model:

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64498949 @jkbradley LGTM. Thanks for the documentation too -- it is really helpful. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-4580] [SPARK-4610] [mllib] Documentatio...

2014-11-25 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/3461 [SPARK-4580] [SPARK-4610] [mllib] Documentation for tree ensembles + DecisionTree API fix Major changes: * Added documentation for tree ensembles * Added examples for tree ensembles *

[GitHub] spark pull request: Implement the efficient vector norm

2014-11-25 Thread dbtsai
GitHub user dbtsai opened a pull request: https://github.com/apache/spark/pull/3462 Implement the efficient vector norm The vector norm in breeze is implemented by `activeIterator` which is known to be very slow. In this PR, an efficient vector norm is implemented, and with

[GitHub] spark pull request: [SPARK-4580] [SPARK-4610] [mllib] Documentatio...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3461#issuecomment-64499904 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4580] [SPARK-4610] [mllib] Documentatio...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3461#issuecomment-64499901 [Test build #23852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23852/consoleFull) for PR 3461 at commit

[GitHub] spark pull request: [SPARK-4580] [SPARK-4610] [mllib] Documentatio...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3461#issuecomment-64499893 [Test build #23852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23852/consoleFull) for PR 3461 at commit

[GitHub] spark pull request: Implement the efficient vector norm

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3462#issuecomment-64500064 [Test build #23851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23851/consoleFull) for PR 3462 at commit

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3439#discussion_r20910282 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala --- @@ -45,19 +46,21 @@ object LogLoss extends Loss { model:

[GitHub] spark pull request: Implement the efficient vector norm

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3462#issuecomment-64500520 [Test build #23853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23853/consoleFull) for PR 3462 at commit

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-25 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/2524#discussion_r20910810 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -21,7 +21,7 @@ import java.io.NotSerializableException import

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-25 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/2524#discussion_r20910947 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -901,6 +900,33 @@ class DAGScheduler( } } +

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64501800 [Test build #23854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23854/consoleFull) for PR 3439 at commit

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3439#discussion_r20911009 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala --- @@ -45,19 +46,21 @@ object LogLoss extends Loss { model:

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3459#issuecomment-64502167 [Test build #23855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23855/consoleFull) for PR 3459 at commit

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64502217 Updated LogLoss. @mengxr @manishamde Thanks for looking at this! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-25 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/2524#discussion_r20911158 --- Diff: docs/programming-guide.md --- @@ -1228,6 +1228,11 @@ interface to accumulate data where the resulting type is not the same as the ele a list by

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3459#discussion_r20911152 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -28,13 +28,16 @@ import org.apache.spark.rdd.RDD

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-25 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/2524#discussion_r20911191 --- Diff: core/src/main/scala/org/apache/spark/Accumulators.scala --- @@ -252,10 +254,9 @@ private object Accumulators { val localAccums = Map[Thread,

[GitHub] spark pull request: [Spark-4509] Revert EC2 tag-based cluster memb...

2014-11-25 Thread mengxr
Github user mengxr closed the pull request at: https://github.com/apache/spark/pull/3453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-25 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/2524#discussion_r20911221 --- Diff: core/src/main/scala/org/apache/spark/Accumulators.scala --- @@ -252,10 +254,9 @@ private object Accumulators { val localAccums = Map[Thread,

[GitHub] spark pull request: [SPARK-732][SPARK-3628][CORE][RESUBMIT] elimin...

2014-11-25 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/2524#issuecomment-64502369 @CodingCat thanks for the update, this looks good. I just made a few small comments. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64502623 [Test build #23856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23856/consoleFull) for PR 3439 at commit

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64502742 [Test build #23856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23856/consoleFull) for PR 3439 at commit

[GitHub] spark pull request: [SPARK-4583] [mllib] LogLoss for GradientBoost...

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3439#issuecomment-64502745 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4612Reduce task latency by making confi...

2014-11-25 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/3463 [SPARK-4612Reduce task latency by making configuration initialization lazy You can merge this pull request into a Git repository by running: $ git pull https://github.com/tdas/spark lazy-config

[GitHub] spark pull request: [SPARK-4612] Reduce task latency and increase ...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3463#issuecomment-64503431 [Test build #23857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23857/consoleFull) for PR 3463 at commit

[GitHub] spark pull request: [SPARK-4612] Reduce task latency and increase ...

2014-11-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3463#issuecomment-64503522 BTW this was added in https://github.com/apache/spark/commit/b6cf1348170951396a6a5d8a65fb670382304f5b by @vanzin. Note that Hadoop configuration object is

[GitHub] spark pull request: [SPARK-4580] [SPARK-4610] [mllib] Documentatio...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3461#issuecomment-64503813 [Test build #23858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23858/consoleFull) for PR 3461 at commit

[GitHub] spark pull request: [SPARK-4580] [SPARK-4610] [mllib] Documentatio...

2014-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3461#issuecomment-64503902 [Test build #23858 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23858/consoleFull) for PR 3461 at commit

[GitHub] spark pull request: [SPARK-4604][MLLIB] make MatrixFactorizationMo...

2014-11-25 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3459#issuecomment-64503911 @mengxr Except for the imports, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    1   2   3   4   >