Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88369109
@mengxr fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/5267#issuecomment-88386004
@yu-iskw great putting this new version together, I'd be happy to do a
review (especially re: the algorithm), should be able to get to it in the next
few days!
---
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88388611
I've updated the description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88388558
[Test build #29525 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29525/consoleFull)
for PR 5306 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88388576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88366992
[Test build #29523 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29523/consoleFull)
for PR 5232 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88366980
[Test build #29522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29522/consoleFull)
for PR 5303 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5306#issuecomment-88370940
[Test build #29525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29525/consoleFull)
for PR 5306 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5144#issuecomment-88377210
[Test build #29528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29528/consoleFull)
for PR 5144 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5144#issuecomment-88377447
[Test build #29528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29528/consoleFull)
for PR 5144 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5308#issuecomment-88383888
I think this was opened in error. Mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88388972
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88388968
[Test build #29531 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29531/consoleFull)
for PR 2342 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88395447
[Test build #29527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29527/consoleFull)
for PR 5303 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5236#issuecomment-88367541
[Test build #29524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29524/consoleFull)
for PR 5236 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88371439
[Test build #29526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29526/consoleFull)
for PR 5303 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88377697
[Test build #29523 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29523/consoleFull)
for PR 5232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5307#issuecomment-88381961
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5236#issuecomment-88384432
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5236#issuecomment-88384404
[Test build #29524 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29524/consoleFull)
for PR 5236 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88369609
[Test build #29522 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29522/consoleFull)
for PR 5303 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88369619
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88382376
[Test build #29531 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29531/consoleFull)
for PR 2342 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88395481
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/spark/pull/5236#discussion_r27547205
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/JavaUtils.java ---
@@ -121,4 +123,69 @@ private static boolean isSymlink(File file)
GitHub user Sephiroth-Lin opened a pull request:
https://github.com/apache/spark/pull/5305
[SPARK-4346][SPARK-3596][YARN] Commonize the monitor logic
1. YarnClientSchedulerBack.asyncMonitorApplication use
Client.monitorApplication so that commonize the monitor logic
2. Support
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/5306
[SPARK-6640][Core] Fix the race condition of creating HeartbeatReceiver and
retrieving HeartbeatReceiver
This PR moved the code of creating `HeartbeatReceiver` above the code of
creating
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5305#issuecomment-88370859
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88373259
[Test build #29526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29526/consoleFull)
for PR 5303 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88373268
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5303#issuecomment-88375070
[Test build #29527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29527/consoleFull)
for PR 5303 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5144#issuecomment-88377450
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88380959
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88380636
[Test build #29530 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29530/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88380951
[Test build #29530 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29530/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5308#issuecomment-88383965
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88384073
[Test build #29532 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29532/consoleFull)
for PR 5208 at commit
Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/5236#issuecomment-88367369
Last batch of comments incorporated. Thanks for the thorough review,
Marcelo!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user kellyzly opened a pull request:
https://github.com/apache/spark/pull/5307
[Spark-5682] Add spark encrypted shuffle by using chimera lib
[Chimera](https://github.com/intel-hadoop/chimera) is a project which
strips code related to CryptoInputStream/CryptoOutputStream from
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88380645
[Test build #29529 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29529/consoleFull)
for PR 5232 at commit
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5234#discussion_r27551218
--- Diff:
network/common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88387039
[Test build #29532 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29532/consoleFull)
for PR 5208 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88387055
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/5267#issuecomment-88387155
@freeman-lab, Thank you for your attention to this matter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5305#issuecomment-88416831
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4708
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88430604
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88399763
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88399749
[Test build #29533 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29533/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88409388
[Test build #29535 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29535/consoleFull)
for PR 2342 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88426945
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88429222
[Test build #29534 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29534/consoleFull)
for PR 2342 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5277#issuecomment-88429046
LGTM. I'll wait a bit for more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88429242
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5305#issuecomment-88418359
[Test build #29536 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29536/consoleFull)
for PR 5305 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5249#issuecomment-88429750
LGTM. Let me see if anyone else has comments today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88403013
[Test build #29529 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29529/consoleFull)
for PR 5232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88403050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88400722
[Test build #29534 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29534/consoleFull)
for PR 2342 at commit
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88403702
I am not getting this error locally... what's wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88410873
This exception only exists on current master, I didn't get this locally
because I was working on a March-26 master. This could be a potential bug we
introduced
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5305#issuecomment-88416792
Jenkins, add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88427545
[Test build #29537 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29537/consoleFull)
for PR 5115 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88457523
[Test build #29542 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29542/consoleFull)
for PR 5232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88466712
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5309#issuecomment-88466471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5309#issuecomment-88466458
[Test build #29540 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29540/consoleFull)
for PR 5309 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88471774
Jenkins, retest this please. (Timeout again.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88377719
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user wesleydias opened a pull request:
https://github.com/apache/spark/pull/5308
Branch 1.3
[SPARK-6639] Create a new script to start multiple masters
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/spark branch-1.3
Github user wesleydias closed the pull request at:
https://github.com/apache/spark/pull/5308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wesleydias commented on the pull request:
https://github.com/apache/spark/pull/5308#issuecomment-88385309
please ignore this git pull request. It was an error pull.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5234#discussion_r27550909
--- Diff:
network/common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5208#issuecomment-88394118
[Test build #29533 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29533/consoleFull)
for PR 5208 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5309#issuecomment-88466705
[Test build #29543 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29543/consoleFull)
for PR 5309 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88436865
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-88436860
[Test build #29535 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29535/consoleFull)
for PR 2342 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5153#issuecomment-88438498
Mind closing this PR? (Jenkins invocation) Obviously it's fine but needs to
go in vs `master`.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5305#issuecomment-88438406
[Test build #29536 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29536/consoleFull)
for PR 5305 at commit
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/5309
[SPARK-6647][SQL] Make trait StringComparison as BinaryPredicate and throw
error when Predicate can't translate to data source Filter
Now trait `StringComparison` is a `BinaryExpression`. In fact,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88448901
[Test build #29539 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29539/consoleFull)
for PR 5115 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5296#issuecomment-88450271
[Test build #29541 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29541/consoleFull)
for PR 5296 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5223#issuecomment-88438010
Yeah this is looking good. I identified some more instances that might use
the same treatment; have a look and see what you think:
- Utils.RedirectThread.run()
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5309#issuecomment-8836
[Test build #29540 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29540/consoleFull)
for PR 5309 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5305#issuecomment-88438430
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88435493
[Test build #29538 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29538/consoleFull)
for PR 5119 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88441092
[Test build #29537 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29537/consoleFull)
for PR 5115 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88441113
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88443201
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88443295
[Test build #29539 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29539/consoleFull)
for PR 5115 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88448906
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-88449046
@achanda these test failures look legit. Did you observe these locally? One
or both of these changes may not be correct.
---
If your project is set up for it, you can
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5265#issuecomment-88483280
Merged to master. Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5247#issuecomment-88479176
cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88487533
[Test build #29542 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29542/consoleFull)
for PR 5232 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88487550
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88473571
[Test build #29544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29544/consoleFull)
for PR 5119 at commit
1 - 100 of 365 matches
Mail list logo