[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41587930 --- Diff: core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41587896 --- Diff: core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10855] [SQL] Add a JDBC dialect for Apa...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8982#issuecomment-146727544 [Test build #43436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43436/console) for PR 8982 at commit

[GitHub] spark pull request: [SPARK-10855] [SQL] Add a JDBC dialect for Apa...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8982#issuecomment-146727613 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10767][PYSPARK] Make pyspark shared par...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9017#issuecomment-146728663 [Test build #43447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43447/console) for PR 9017 at commit

[GitHub] spark pull request: [SPARK-10767][PYSPARK] Make pyspark shared par...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9017#issuecomment-146728730 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10767][PYSPARK] Make pyspark shared par...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9017#issuecomment-146728731 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146729669 [Test build #43450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43450/consoleFull) for PR 9000 at commit

[GitHub] spark pull request: [SPARK-8386] [SQL]add write.mode for insertInt...

2015-10-08 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/9042 [SPARK-8386] [SQL]add write.mode for insertIntoJDBC when the parm overwrite is false the fix is for jira https://issues.apache.org/jira/browse/SPARK-8386 You can merge this pull request

[GitHub] spark pull request: [SPARK-11007] [SQL] Adds dictionary aware Parq...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9040#issuecomment-146732928 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11007] [SQL] Adds dictionary aware Parq...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9040#issuecomment-146732725 [Test build #43443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43443/console) for PR 9040 at commit

[GitHub] spark pull request: [SPARK-10973][ML][PYTHON] __gettitem__ method ...

2015-10-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9009#issuecomment-146732821 merging with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10515] When killing executor, the pendi...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8945#issuecomment-146732399 [Test build #43453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43453/consoleFull) for PR 8945 at commit

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146734813 [Test build #43452 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43452/console) for PR 9041 at commit

[GitHub] spark pull request: [SPARK-11020] [core] Wait for HDFS to leave sa...

2015-10-08 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/9043 [SPARK-11020] [core] Wait for HDFS to leave safe mode before initializing HS. Large HDFS clusters may take a while to leave safe mode when starting; this change makes the HS wait for that

[GitHub] spark pull request: [SPARK-11020] [core] Wait for HDFS to leave sa...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9043#issuecomment-146734763 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10955][streaming] Add a warning if dyna...

2015-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8998 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11020] [core] Wait for HDFS to leave sa...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9043#issuecomment-146735610 [Test build #43455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43455/consoleFull) for PR 9043 at commit

[GitHub] spark pull request: [SPARK-10739][Yarn] Add application attempt wi...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8857#discussion_r41593173 --- Diff: docs/running-on-yarn.md --- @@ -304,6 +304,14 @@ If you need a reference to the proper location to put log files in the YARN so t

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146740993 [Test build #43449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43449/console) for PR 9036 at commit

[GitHub] spark pull request: [SPARK-10739][Yarn] Add application attempt wi...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8857#discussion_r41593235 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -185,6 +185,23 @@ private[spark] class Client( case None =>

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146741058 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146745125 [Test build #43445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43445/console) for PR 9000 at commit

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146751458 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146751462 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146752602 LGTM pending test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41585457 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoOutputStream.scala --- @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10599] Lower communication for block ma...

2015-10-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-146720466 Making a pass now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10599] Lower communication for block ma...

2015-10-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8757#discussion_r41586254 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -352,6 +353,30 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-10599] Lower communication for block ma...

2015-10-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8757#discussion_r41586262 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -352,6 +353,30 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41586275 --- Diff: core/src/main/scala/org/apache/spark/crypto/JceAesCtrCryptoCodec.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10599] Lower communication for block ma...

2015-10-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8757#discussion_r41586259 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -352,6 +353,30 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146723009 [Test build #43444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43444/consoleFull) for PR 9041 at commit

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41587132 --- Diff: core/src/test/scala/org/apache/spark/crypto/JceAesCtrCryptoCodecSuite.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10250][CORE] External group by to handl...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8438#issuecomment-146725820 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146725895 [Test build #43444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43444/console) for PR 9041 at commit

[GitHub] spark pull request: [SPARK-10810] [SPARK-10902] [SQL] Improve sess...

2015-10-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8909#issuecomment-146725869 Merged into master, new comments will be addressed in follow-up PR, thanks you all! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-10810] [SPARK-10902] [SQL] Improve sess...

2015-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8909 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10250][CORE] External group by to handl...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8438#issuecomment-146725821 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41587038 --- Diff: core/src/test/scala/org/apache/spark/crypto/JceAesCtrCryptoCodecSuite.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9036#discussion_r41587125 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercionSuite.scala --- @@ -470,7 +470,8 @@ class

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146725914 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41587190 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -17,6 +17,7 @@ package org.apache.spark.deploy.yarn

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41587851 --- Diff: core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41587795 --- Diff: core/src/test/scala/org/apache/spark/StaticMemoryManagerSuite.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10990] [SPARK-11018] [SQL] improve unro...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146727257 [Test build #43448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43448/consoleFull) for PR 9016 at commit

[GitHub] spark pull request: [SPARK-8552] [THRIFTSERVER] Using incorrect da...

2015-10-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7118#issuecomment-146727231 Since #8909 is merged, would you mind close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9036#issuecomment-146729170 [Test build #43449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43449/consoleFull) for PR 9036 at commit

[GitHub] spark pull request: [SPARK-10665][SQL] Query planner infra for loc...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9039#issuecomment-146730022 [Test build #43451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43451/console) for PR 9039 at commit

[GitHub] spark pull request: [SPARK-10665][SQL] Query planner infra for loc...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9039#issuecomment-146730024 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10665][SQL] Query planner infra for loc...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9039#issuecomment-146730023 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146730016 This basically makes testing a bit more predictable. Sometimes, we end up hitting a situation where the last transaction is still not completed and the

[GitHub] spark pull request: [SPARK-10665][SQL] Query planner infra for loc...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9039#issuecomment-146729982 [Test build #43451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43451/consoleFull) for PR 9039 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146731721 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146733140 LGTM. Feel free to merge pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11020] [core] Wait for HDFS to leave sa...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9043#issuecomment-146734747 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146735090 LGTM. Merging it master and branch 1.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146734952 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146734953 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8654] [SQL] Analysis exception when usi...

2015-10-08 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/9036#discussion_r41595658 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -304,7 +304,10 @@ object HiveTypeCoercion {

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41584529 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoOutputStream.scala --- @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11007] [SQL] Adds dictionary aware Parq...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9040#issuecomment-146718396 [Test build #43443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43443/consoleFull) for PR 9040 at commit

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146718407 LGTM, by the way, pending updates to address comments. The majority of the unaddressed comments are minor and nitpicky, but I think that

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146721247 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146721142 [Test build #43434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43434/console) for PR 9030 at commit

[GitHub] spark pull request: [SPARK-10914] UnsafeRow serialization breaks w...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9030#issuecomment-146721248 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41586239 --- Diff: core/src/main/scala/org/apache/spark/crypto/JceAesCtrCryptoCodec.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10599] Lower communication for block ma...

2015-10-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8757#discussion_r41586252 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -60,6 +60,7 @@ private[mllib] class GridPartitioner(

[GitHub] spark pull request: [SPARK-10810] [SPARK-10902] [SQL] Improve sess...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8909#issuecomment-146725227 Non-hive parts LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41586770 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala --- @@ -80,12 +83,28 @@ private[spark] class DiskBlockObjectWriter(

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8962#discussion_r41586812 --- Diff: R/pkg/R/DataFrame.R --- @@ -1873,3 +1872,30 @@ setMethod("as.data.frame", collect(x) } ) + +#'

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/8962#discussion_r41586805 --- Diff: R/pkg/R/DataFrame.R --- @@ -1873,3 +1872,30 @@ setMethod("as.data.frame", collect(x) } ) + +#'

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41586814 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -21,13 +21,17 @@ import java.io.InputStream import

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41587282 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -608,6 +612,18 @@ private[spark] class ApplicationMaster( }

[GitHub] spark pull request: [SPARK-10990] [SPARK-11018] [SQL] improve unro...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9016#issuecomment-146732468 [Test build #43439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43439/console) for PR 9016 at commit

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146735295 Actually, there were small conflicts in branch 1.5, so I only merged to master. Seems fine, not a highpriority bug that 1.5 should get it. --- If your project is set up

[GitHub] spark pull request: [SPARK-10955][streaming] Add a warning if dyna...

2015-10-08 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/8998#issuecomment-146735373 LGTM, merging this to master and branch 1.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9041 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10515] When killing executor, the pendi...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8945#issuecomment-146737544 Thanks LGTM. I'll merge this once tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARKR] [SPARK-10981] SparkR Join improvement...

2015-10-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9029#discussion_r41592873 --- Diff: R/pkg/R/DataFrame.R --- @@ -1314,50 +1273,21 @@ setClassUnion("characterOrColumn", c("character", "Column")) #' path <-

[GitHub] spark pull request: [SPARK-10905][SparkR]: Export freqItems() for ...

2015-10-08 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/8962#discussion_r41592900 --- Diff: R/pkg/R/stats.R --- @@ -100,3 +100,30 @@ setMethod("corr", statFunctions <- callJMethod(x@sdf, "stat")

[GitHub] spark pull request: [SPARKR] [SPARK-10981] SparkR Join improvement...

2015-10-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9029#discussion_r41592919 --- Diff: R/pkg/R/DataFrame.R --- @@ -1854,30 +1784,36 @@ setMethod("fillna", sdf <- if (length(cols) == 0) {

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread winningsix
Github user winningsix commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41593638 --- Diff: core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10989] [MLLIB] Added the dot and hadama...

2015-10-08 Thread da-steve101
Github user da-steve101 commented on a diff in the pull request: https://github.com/apache/spark/pull/9020#discussion_r41593650 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -512,6 +513,92 @@ object Vectors { squaredDistance }

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146747085 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146747083 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10515] When killing executor, the pendi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8945#issuecomment-146747357 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10515] When killing executor, the pendi...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8945#issuecomment-146747096 [Test build #43453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43453/console) for PR 8945 at commit

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146747027 [Test build #43450 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43450/console) for PR 9000 at commit

[GitHub] spark pull request: [SPARK-10515] When killing executor, the pendi...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8945#issuecomment-146747359 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10772][Streaming][Scala]: NullPointerEx...

2015-10-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/8881#discussion_r41584948 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/TransformedDStream.scala --- @@ -38,6 +39,11 @@ class TransformedDStream[U: ClassTag] (

[GitHub] spark pull request: SPARK-10771: Implement the shuffle encryption ...

2015-10-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r41585773 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoCodec.scala --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146724990 /cc @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10767][PYSPARK] Make pyspark shared par...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9017#issuecomment-146726910 [Test build #43447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43447/consoleFull) for PR 9017 at commit

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41587618 --- Diff: core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala --- @@ -1040,17 +1044,23 @@ class BlockManagerSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9000#discussion_r41588629 --- Diff: core/src/main/scala/org/apache/spark/StaticMemoryManager.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146729372 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146729383 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11019][streaming][flume] Gracefully shu...

2015-10-08 Thread harishreedharan
Github user harishreedharan commented on the pull request: https://github.com/apache/spark/pull/9041#issuecomment-146730211 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10956] Common MemoryManager interface f...

2015-10-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9000#issuecomment-146730232 @JoshRosen alright I believe I addressed all of your comments. Please let me know if it LGTY. --- If your project is set up for it, you can reply to this email and

<    2   3   4   5   6   7   8   9   10   >