[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10808#discussion_r51492455 --- Diff: core/src/main/scala/org/apache/spark/executor/MesosExecutorBackend.scala --- @@ -18,6 +18,7 @@ package org.apache.spark.executor

[GitHub] spark pull request: [SPARK-5095] [Mesos] Support launching multipl...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10993#issuecomment-178231262 **[Test build #50506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50506/consoleFull)** for PR 10993 at commit [`318486e`](https://gi

[GitHub] spark pull request: [SPARK-10570][Core] Add version info to json a...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10760#issuecomment-178231371 **[Test build #50507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50507/consoleFull)** for PR 10760 at commit [`65d74b0`](https://gi

[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-178231238 @dragos is the only thing that's left before this patch can be merged the escaping thing? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-178230973 @jayv the closest thing I can think of is `Utils.splitCommandString`, which does the unescaping. Did you end up getting Mesos to escape things properly? E.g. does so

[GitHub] spark pull request: [SPARK-12316] Wait a minutes to avoid cycle ca...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10475#issuecomment-178225888 @tgravescs @harishreedharan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5095] [Mesos] Support launching multipl...

2016-02-01 Thread mgummelt
Github user mgummelt commented on the pull request: https://github.com/apache/spark/pull/10993#issuecomment-178225729 I made an update that should fix the test. I've tested in cluster mode, but not with dynamic allocation. Though I have added some unit tests that cover dynami

[GitHub] spark pull request: [SPARK-12958] [CORE] Adding Map accumulator St...

2016-02-01 Thread sourind
Github user sourind commented on the pull request: https://github.com/apache/spark/pull/10907#issuecomment-178224859 Sure. --Souri On Mon, Feb 1, 2016 at 2:00 PM, andrewor14 wrote: > I agree with @JoshRosen . It seems this map

[GitHub] spark pull request: [SPARK-10570][Core] Add version info to json a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10760#issuecomment-178224867 ok to test. This change looks OK to me. @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51490255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -180,6 +221,46 @@ case class Join(

[GitHub] spark pull request: [SPARK-12836][CORE] Fix spark enable both driv...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10770#issuecomment-178224492 **[Test build #50505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50505/consoleFull)** for PR 10770 at commit [`4251d8e`](https://gi

[GitHub] spark pull request: [SPARK-13078][SQL] API and test cases for inte...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10982#discussion_r51490294 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request: Refactor ExecutorAllocationManager.

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10761#issuecomment-178224421 @kevincox please follow https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark. This task needs a JIRA and you need to link it in the title. For big

[GitHub] spark pull request: [SPARK-11703] [Docker] Fix spark-mesos Dockerf...

2016-02-01 Thread lmtjalves
Github user lmtjalves closed the pull request at: https://github.com/apache/spark/pull/9301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-13078][SQL] API and test cases for inte...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10982 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-11703] [Docker] Fix spark-mesos Dockerf...

2016-02-01 Thread lmtjalves
Github user lmtjalves commented on the pull request: https://github.com/apache/spark/pull/9301#issuecomment-178224213 @JoshRosen I'm going to close then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-12988][SQL] Can't drop columns that con...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10943#issuecomment-178223443 ah, change `select(output.updated(index, col.as(colName)).map(Column(_)) : _*)` to `select(output.map(Column(_)).updated(index, col.as(colName)): _*)` should work -

[GitHub] spark pull request: [SPARK-13078][SQL] API and test cases for inte...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10982#issuecomment-178223505 Thanks - merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12637] [CORE] Print stage info of finis...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10922#issuecomment-178223105 **[Test build #50504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50504/consoleFull)** for PR 10922 at commit [`4e997a2`](https://gi

[GitHub] spark pull request: [SPARK-12832][CORE] Fix dispatcher does not ha...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10768#issuecomment-178223014 Also @Astralidea please change the title to include `[MESOS]` instead of `[CORE]` --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-12836][CORE] Fix spark enable both driv...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10770#issuecomment-178222685 @Astralidea have you tried setting `SPARK_USER`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-12836][CORE] Fix spark enable both driv...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10770#discussion_r51489300 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -133,7 +133,7 @@ private[spark] class Coa

[GitHub] spark pull request: SPARK-13052 waitingApps metric doesn't show th...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10959#issuecomment-178221800 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-13052 waitingApps metric doesn't show th...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10959#issuecomment-178221806 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12836][CORE] Fix spark enable both driv...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10770#issuecomment-178220727 ok to test. @tnachen @dragos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12836][CORE] Fix spark enable both driv...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10770#issuecomment-178220662 @Astralidea can you rename the title to say `[MESOS]` instead of `[CORE]`? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178220782 **[Test build #50501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50501/consoleFull)** for PR 11007 at commit [`78c0323`](https://gi

[GitHub] spark pull request: [SPARK-12790][CORE] Remove HistoryServer old m...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10860#issuecomment-178220256 **[Test build #50503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50503/consoleFull)** for PR 10860 at commit [`f829ac7`](https://gi

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10794#issuecomment-178218750 @vanzin @jerryshao IIRC there's a similar patch somewhere to fix this issue? --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-12988][SQL] Can't drop columns that con...

2016-02-01 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10943#issuecomment-178218207 @cloud-fan Hi Wenchen, couldn't get the code snippet to compile and i made a change that looks like the following. def withColumn(colName: String, col: Colu

[GitHub] spark pull request: [SPARK-12893][YARN] Fix history URL redirect e...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10821#issuecomment-178217656 @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-178217564 @lianhuiwang could you update this PR to resolve the conflicts? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Fix for [SPARK-12854][SQL] Implement complex t...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12958] [CORE] Adding Map accumulator St...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10907#issuecomment-178216544 I agree with @JoshRosen. It seems this map param is essentially a collection of a few individual Long accums, and the user can manage that better themselves. Also, t

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10961 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: Fix for [SPARK-12854][SQL] Implement complex t...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10946#issuecomment-178214823 Merging this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8171] [Web UI] Simulated infinite scrol...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10910#issuecomment-178214734 @sarutak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-13043][SQL] Implement remaining catalys...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10961#issuecomment-178214178 Going to merge this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12994][CORE] It is not necessary to cre...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10914#issuecomment-178214411 I agree with the change, but I think it could be made in a better place. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12994][CORE] It is not necessary to cre...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10914#discussion_r51487361 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -537,7 +537,8 @@ class SparkContext(config: SparkConf) extends Logging with Execu

[GitHub] spark pull request: [SPARK-12637] [CORE] Print stage info of finis...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10922#issuecomment-178213394 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-12637] [CORE] Print stage info of finis...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10922#discussion_r51487013 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -296,6 +296,17 @@ class StatsReportListener extends SparkListener with

[GitHub] spark pull request: SPARK-13052 waitingApps metric doesn't show th...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10959#issuecomment-178212137 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12637] [CORE] Print stage info of finis...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10922#issuecomment-178212484 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178210304 @gabrielenizzoli Thanks, good catch. Please follow the instructions in https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark --- If your project is s

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178209926 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-01 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-178209754 @zsxwing Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178206958 Hi @gabrielenizzoli - generally Spark require's that there is a JIRA associated the proposed change as well as having it mentioned in the pull request title. This is al

[GitHub] spark pull request: [SPARK-11703] [Docker] Fix spark-mesos Dockerf...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9301#issuecomment-178206669 @dragos @tnachen would one of you be willing to take this up and address the remaining comments? --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: [SPARK-12979][Mesos] Don’t resolve paths on ...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10923 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [test-maven] Shade protobuf-java

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10995#issuecomment-178205893 @tedyu could you create a JIRA and add it to the title? This change is worth to have a JIRA to track. Ping @srowen @JoshRosen to take a look. --- If your proj

[GitHub] spark pull request: [SPARK-12979][Mesos] Don’t resolve paths on ...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10923#issuecomment-178205720 Merged into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13001] [CORE] [MESOS] Prevent getting o...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10924#issuecomment-178199062 @tnachen @dragos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178205092 Looks great! Just some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-12265][Mesos] Spark calls System.exit i...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10921 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12265][Mesos] Spark calls System.exit i...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10921#issuecomment-178204415 LGTM merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51483601 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala --- @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [test-maven] Shade protobuf-java

2016-02-01 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10995#issuecomment-178202908 This would still benefit Spark standalone and Spark on Mesos, right ? For Spark on YARN, status quo is maintained. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51483011 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala --- @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482488 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/ConstraintPropagationSuite.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed t

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482277 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -180,6 +221,46 @@ case class Join( }

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -89,9 +89,27 @@ case class Generate(

[GitHub] spark pull request: [test-maven] Shade protobuf-java

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10995#issuecomment-178197729 Since Hadoop doesn't shade `protobuf`, I think this won't fix the issue in the PR description. Right? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482081 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -180,6 +221,46 @@ case class Join( }

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8872#issuecomment-178195492 @tnachen echoing my comment from another PR: it seems that this feature is already supported in client mode but not in cluster mode. Is there something we can do abou

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51481347 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51481128 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala --- @@ -0,0 +1,139 @@ +/* --- End diff --

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178191582 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51481006 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -525,14 +531,14 @@ private[spark] class MesosClu

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178191589 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178190775 **[Test build #50498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50498/consoleFull)** for PR 11006 at commit [`7147b3f`](https://g

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178190454 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51480776 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -497,28 +505,28 @@ private[spark] class MesosClu

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread gabrielenizzoli
GitHub user gabrielenizzoli opened a pull request: https://github.com/apache/spark/pull/11007 java mapwithstate, broken java mapping java mapwithstate with Function3 has wrong conversion of java Optional to scala Option, now code uses same conversion used in the mapwithstate call th

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51480535 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -456,34 +460,36 @@ private[spark] class MesosClu

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51480355 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178189170 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178189155 **[Test build #50500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50500/consoleFull)** for PR 10949 at commit [`7c6650d`](https://g

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178189166 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10989#issuecomment-178188600 **[Test build #2486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2486/consoleFull)** for PR 10989 at commit [`c1c0588`](https://

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51480080 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51478445 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -180,6 +221,46 @@ case class Join( }

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178181958 **[Test build #50500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50500/consoleFull)** for PR 10949 at commit [`7c6650d`](https://gi

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51478334 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-12463][SPARK-12464][SPARK-12465][SPARK-...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10057 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12992][SQL]: Update parquet reader to s...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10908#issuecomment-178179979 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12463][SPARK-12464][SPARK-12465][SPARK-...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10057#issuecomment-178180002 Merged into master. By the way I might have mentioned this before but you probably don't need 3 different issues to rename 3 configs. --- If your project is set up

[GitHub] spark pull request: [SPARK-12992][SQL]: Update parquet reader to s...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10908#issuecomment-178179976 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12992][SQL]: Update parquet reader to s...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10908#issuecomment-178179904 **[Test build #50499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50499/consoleFull)** for PR 10908 at commit [`2ea2d54`](https://g

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10989#issuecomment-178179456 Can you include the generated code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r51477107 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -54,13 +54,27 @@ public void setInput(Iterator iter) {

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178178205 By the way, I'd just like to point out that there is another patch that fixes the same issue #10768. @tnachen @dragos what's the difference and which one should we p

[GitHub] spark pull request: [SPARK-12832][CORE] Fix dispatcher does not ha...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10768#issuecomment-178178342 FYI #10949 is another patch for the same issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476990 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the Apach

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178177036 Also cc @tnachen who wrote this code originally. From the JIRA: > CoarseMesosSchedulerBackend have constraints feature but dispacher deploy use MesosClusterSchedu

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476822 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the Apach

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476814 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the Apach

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476807 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the Apach

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10949#discussion_r51476513 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -461,13 +461,16 @@ private[spark] class MesosCl

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178174598 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

<    1   2   3   4   5   6   7   >