[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11436#issuecomment-190522408 Alright, took another shot at addressing the correctness issue. Will address other comments after tests pass. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11136#issuecomment-190522461 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11136#issuecomment-190522465 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11136#issuecomment-190522453 **[Test build #52211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52211/consoleFull)** for PR 11136 at commit

[GitHub] spark pull request: [SPARK-13586]add config to skip generate down ...

2016-02-29 Thread jeanlyn
GitHub user jeanlyn opened a pull request: https://github.com/apache/spark/pull/11440 [SPARK-13586]add config to skip generate down time batch when restart StreamingContext ## What changes were proposed in this pull request? The patch try to add a config

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11136#issuecomment-190520555 **[Test build #52211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52211/consoleFull)** for PR 11136 at commit

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54518547 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-13493][SQL] Enable case sensitiveness i...

2016-02-29 Thread zuowang
Github user zuowang commented on the pull request: https://github.com/apache/spark/pull/11420#issuecomment-190519404 What would be the case like in CSV? I don't think anybody want to conbine "user" and "User" column when "caseSensitiveAnalysis" is false. `scala> val jsonDF =

[GitHub] spark pull request: [SPARK-13511][SQL] Add wholestage codegen for ...

2016-02-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11391#discussion_r54517293 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java --- @@ -765,6 +765,9 @@ private void

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190507434 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190507431 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-190507332 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190507323 **[Test build #52207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52207/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-13385][MLlib] Enable AssociationRules t...

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11411#issuecomment-190507307 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11436#issuecomment-190500180 There's one corner-case which this patch doesn't handle correctly: if we are trying to cache a block, start unrolling the iterator, and then conclude that the

[GitHub] spark pull request: [SPARK-11517][SQL]Calc partitions in parallel ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9483#issuecomment-190497524 **[Test build #52210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52210/consoleFull)** for PR 9483 at commit

[GitHub] spark pull request: [SPARK-11517][SQL]Calc partitions in parallel ...

2016-02-29 Thread zhichao-li
Github user zhichao-li commented on the pull request: https://github.com/apache/spark/pull/9483#issuecomment-190497155 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13233][SQL] Python Dataset (basic versi...

2016-02-29 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11347#issuecomment-190493809 Will send a simpler version that just use RDD. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13233][SQL] Python Dataset (basic versi...

2016-02-29 Thread cloud-fan
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/11347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190487647 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190487649 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190487554 **[Test build #52209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52209/consoleFull)** for PR 11417 at commit

[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-190486901 @sethah GaussianMixture is a kind of clustering algorithm, not classification. And ProbabilisticClassifier extend Predictor, so it has a "setLabelCol"

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190486545 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190486542 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190486478 **[Test build #52208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52208/consoleFull)** for PR 11417 at commit

[GitHub] spark pull request: [SPARK-13584][SQL][Tests]Make ContinuousQueryM...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11439#issuecomment-190485958 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13584][SQL][Tests]Make ContinuousQueryM...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11439#issuecomment-190485953 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13584][SQL][Tests]Make ContinuousQueryM...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11439#issuecomment-190485102 **[Test build #52204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52204/consoleFull)** for PR 11439 at commit

[GitHub] spark pull request: [SPARK-13550] [ML] Add java example for ml.clu...

2016-02-29 Thread zhengruifeng
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/11428#issuecomment-190484554 @srowen this is the first java example for ml.clustering.BisectingKMeans --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190483710 Hi, @srowen . I've test more, but found that `-Ywarn-unused-import` option is not reliable yet in Scala 2.11.7. Please refer

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190483330 **[Test build #52209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52209/consoleFull)** for PR 11417 at commit

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190481661 @yhuai @nongli Had update the doc string of innerChildren and treeChildren to include a example. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-13415] [SQL] Visualize subquery in SQL ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11417#issuecomment-190481457 **[Test build #52208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52208/consoleFull)** for PR 11417 at commit

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190479973 **[Test build #52207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52207/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190477588 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190477587 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190477582 **[Test build #52206 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52206/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190477384 **[Test build #52206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52206/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11136#issuecomment-190477077 I made one pass on the tests, only some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508437 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508443 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508387 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508365 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508381 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508392 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508370 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-29 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11136#discussion_r54508383 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -0,0 +1,499 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-13398][STREAMING] Move away from thread...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11423#issuecomment-190476768 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13398][STREAMING] Move away from thread...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11423#issuecomment-190476770 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13398][STREAMING] Move away from thread...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11423#issuecomment-190476600 **[Test build #52201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52201/consoleFull)** for PR 11423 at commit

[GitHub] spark pull request: [SPARK-12583][Mesos] Mesos shuffle service: Do...

2016-02-29 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/11272#issuecomment-190475702 This looks like a great candidate to add integration tests for in the mesos-spark-integration-tests suite. Ideally we have something long running that we can run.

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190475570 Oh, I see. Then, this PR will not enforce automatically, just helps developers to check before pushing PR. Thank you, @zsxwing ! --- If your project is

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190474729 @dongjoon-hyun I mean `lint-java` will fail on a clean machine without maven cache. It will fail to resolve the snapshot jars which requires running `mvn install` to

[GitHub] spark pull request: [SPARK-12583][Mesos] Mesos shuffle service: Do...

2016-02-29 Thread tnachen
Github user tnachen commented on a diff in the pull request: https://github.com/apache/spark/pull/11272#discussion_r54507553 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/mesos/MesosExternalShuffleClient.java --- @@ -53,21 +65,58 @@ public

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190473820 @srowen , for the scala code, should we take advantage of `-Ywarn-unused-import` option for that in some way? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190473494 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190473496 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190473490 **[Test build #52205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52205/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190473353 Oh, thank you for informing that, @zsxwing . By the way, `dev\lint-java` does not depend on `mvn install`. I think It depends on compiled classes.

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190473204 **[Test build #52205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52205/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-12583][Mesos] Mesos shuffle service: Do...

2016-02-29 Thread tnachen
Github user tnachen commented on a diff in the pull request: https://github.com/apache/spark/pull/11272#discussion_r54506572 --- Diff: core/src/main/scala/org/apache/spark/deploy/mesos/MesosExternalShuffleService.scala --- @@ -93,7 +113,8 @@ private[mesos] class

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-02-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10205#discussion_r54506474 --- Diff: core/src/main/scala/org/apache/spark/config/ConfigBuilder.scala --- @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11436#issuecomment-190472337 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11436#issuecomment-190472334 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11436#issuecomment-190472125 **[Test build #52200 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52200/consoleFull)** for PR 11436 at commit

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-02-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/10205#discussion_r54505940 --- Diff: core/src/main/scala/org/apache/spark/config/ConfigBuilder.scala --- @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11436#issuecomment-190469440 much simpler! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11436#discussion_r54505311 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -648,6 +647,32 @@ private[spark] class BlockManager( }

[GitHub] spark pull request: [SPARK-12817] Add BlockManager.getOrElseUpdate...

2016-02-29 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11436#discussion_r54504911 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -307,29 +307,48 @@ private[storage] class BlockInfoManager extends

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-02-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10205#discussion_r54504477 --- Diff: core/src/main/scala/org/apache/spark/config/ConfigBuilder.scala --- @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190463862 FYI because `mvn checkstyle:check` depends on `mvn install` which cost huge time for `sbt`, java style checker is disabled now:

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190463372 Hi, @srowen . Surprisingly, according to the [ScalaStyle Ruleset](http://www.scalastyle.org/rules-0.8.0.html) , it seems that we can not do that for Scala

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-02-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/10205#discussion_r54502037 --- Diff: core/src/main/scala/org/apache/spark/config/ConfigBuilder.scala --- @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-02-29 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-190456287 > , can you update the description to make it more accurately reflect what this is about? I removed the parts talking about SQL, but the remaining parts talk

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190455685 Thank you, @srowen ! Up to know, I'm not sure about enforcing Scala Imports but I'll check that, too. I'll leave a message soon. By the way,

[GitHub] spark pull request: [SPARK-13584][SQL][Tests]Make ContinuousQueryM...

2016-02-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11439#discussion_r54501420 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/ContinuousQueryManagerSuite.scala --- @@ -83,7 +98,7 @@ class ContinuousQueryManagerSuite

[GitHub] spark pull request: [SPARK-13584][SQL][Tests]Make ContinuousQueryM...

2016-02-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11439#discussion_r54501380 --- Diff: sql/core/src/test/resources/log4j.properties --- @@ -23,6 +23,7 @@ log4j.appender.CA=org.apache.log4j.ConsoleAppender

[GitHub] spark pull request: [SPARK-13584][SQL][Tests]Make ContinuousQueryM...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11439#issuecomment-190455315 **[Test build #52204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52204/consoleFull)** for PR 11439 at commit

[GitHub] spark pull request: [SPARK-13584][SQL][Tests]Make ContinuousQueryM...

2016-02-29 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/11439 [SPARK-13584][SQL][Tests]Make ContinuousQueryManagerSuite not output logs to the console ## What changes were proposed in this pull request? Make ContinuousQueryManagerSuite not output

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-02-29 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-190455028 @vanzin if you don't want to decouple the pr, can you update the description to make it more accurately reflect what this is about? A big part of this is not really about

[GitHub] spark pull request: [SPARK-13255][SQL] Update vectorized reader to...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11435#issuecomment-190454929 **[Test build #2592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2592/consoleFull)** for PR 11435 at commit

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-02-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10205#discussion_r54501087 --- Diff: core/src/main/scala/org/apache/spark/config/ConfigBuilder.scala --- @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190454412 **[Test build #52203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52203/consoleFull)** for PR 11438 at commit

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190453820 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190452909 I'm OK with this. Can we enforce this in Scala too? Since we've bothered to fail the build if imports aren't in the right order I think it's reasonable to

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11438#issuecomment-190452433 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13583][BUILD] Enforce `UnusedImports` J...

2016-02-29 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11438 [SPARK-13583][BUILD] Enforce `UnusedImports` Java checkstyle rule ## What changes were proposed in this pull request? After SPARK-6990, `dev/lint-java` keeps Java code healthy and

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190446124 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190446110 **[Test build #52202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52202/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190446127 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190445236 **[Test build #52202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52202/consoleFull)** for PR 11437 at commit

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11437#issuecomment-190444065 cc @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13582] [SQL] defer dictionary decoding ...

2016-02-29 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/11437 [SPARK-13582] [SQL] defer dictionary decoding in parquet reader ## What changes were proposed in this pull request? This PR defer the resolution from a id of dictionary to value until the

[GitHub] spark pull request: [SPARK-13013][Docs] Replace example code in ml...

2016-02-29 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/6#issuecomment-190443262 @keypointt It's OK to have different examples codes. Let me check it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13398][STREAMING] Move away from thread...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11423#issuecomment-190442571 **[Test build #52201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52201/consoleFull)** for PR 11423 at commit

[GitHub] spark pull request: [SPARK-13571] [SQL] Track current database in ...

2016-02-29 Thread andrewor14
Github user andrewor14 closed the pull request at: https://github.com/apache/spark/pull/11433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-13255][SQL] Update vectorized reader to...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11435#issuecomment-190439315 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13255][SQL] Update vectorized reader to...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11435#issuecomment-190439316 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13255][SQL] Update vectorized reader to...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11435#issuecomment-190439119 **[Test build #52199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52199/consoleFull)** for PR 11435 at commit

<    1   2   3   4   5   >